Re: [Qemu-devel] [PATCH v2 2/9] block: vhdx - add header update capability.

[Jeff Cody <jcody@redhat.com>]

On Mon, Aug 05, 2013 at 01:42:32PM +0200, Kevin Wolf wrote:
> Am 01.08.2013 um 05:23 hat Jeff Cody geschrieben:
> > This adds the ability to update the headers in a VHDX image, including
> > generating a new MS-compatible GUID.
> > 
> > As VHDX depends on uuid.h, VHDX is now a configurable build option.  If
> > VHDX support is enabled, that will also enable uuid as well.  The
> > default is to have VHDX enabled.
> > 
> > To enable/disable VHDX:  --enable-vhdx, --disable-vhdx
> > 
> > Signed-off-by: Jeff Cody <jcody@redhat.com>
> 
> > diff --git a/configure b/configure
> > index 877a821..821b790 100755
> > --- a/configure
> > +++ b/configure
> > @@ -244,6 +244,7 @@ gtk=""
> >  gtkabi="2.0"
> >  tpm="no"
> >  libssh2=""
> > +vhdx="yes"
> >  
> >  # parse CC options first
> >  for opt do
> > @@ -950,6 +951,11 @@ for opt do
> >    ;;
> >    --enable-libssh2) libssh2="yes"
> >    ;;
> > +  --enable-vhdx) vhdx="yes" ;
> > +                 uuid="yes"
> > +  ;;
> 
> What's this? Shouldn't auto-detecting uuid and checking later whether
> it's available do the right thing?
>

You are right, thanks.  Will fix for v3.

> Test cases:
> 
> 1. configure --disable-uuid --enable-vhdx
>    This should result in an error because the options contradict each
>    other. With this patch, the disable flag is overridden.
> 
> 2. No libuuid headers available; ./configure
>    Should build without VHDX. With this patch, uuid is left out, vhdx is
>    configured anyway, the build fails.
> 
> Kevin