From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:57323) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1V6Mqk-0007mU-3B for qemu-devel@nongnu.org; Mon, 05 Aug 2013 11:37:40 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1V6Mqd-0001ER-Pu for qemu-devel@nongnu.org; Mon, 05 Aug 2013 11:37:34 -0400 Date: Mon, 5 Aug 2013 18:39:03 +0300 From: "Michael S. Tsirkin" Message-ID: <20130805153903.GC3814@redhat.com> References: <1375692609-3730-1-git-send-email-kraxel@redhat.com> <51FF7440.1040404@suse.de> <51FF7F6A.50902@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline In-Reply-To: <51FF7F6A.50902@redhat.com> Content-Transfer-Encoding: quoted-printable Subject: Re: [Qemu-devel] [PATCH] pci: fix i82801b11 bridge List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Gerd Hoffmann Cc: qemu-stable , Andreas =?iso-8859-1?Q?F=E4rber?= , qemu-devel@nongnu.org On Mon, Aug 05, 2013 at 12:33:14PM +0200, Gerd Hoffmann wrote: > On 08/05/13 11:45, Andreas F=E4rber wrote: > > Am 05.08.2013 10:50, schrieb Gerd Hoffmann: > >> Signed-off-by: Gerd Hoffmann > >> --- > >> hw/pci-bridge/i82801b11.c | 1 + > >> 1 file changed, 1 insertion(+) > >> > >> diff --git a/hw/pci-bridge/i82801b11.c b/hw/pci-bridge/i82801b11.c > >> index 8a5e426..14cd7fd 100644 > >> --- a/hw/pci-bridge/i82801b11.c > >> +++ b/hw/pci-bridge/i82801b11.c > >> @@ -90,6 +90,7 @@ static void i82801b11_bridge_class_init(ObjectClas= s *klass, void *data) > >> k->device_id =3D PCI_DEVICE_ID_INTEL_82801BA_11; > >> k->revision =3D ICH9_D2P_A2_REVISION; > >> k->init =3D i82801b11_bridge_initfn; > >> + k->config_write =3D pci_bridge_write_config; > >> set_bit(DEVICE_CATEGORY_BRIDGE, dc->categories); > >> } > >> =20 > >=20 > > We have an abstract TYPE_PCI_BRIDGE now, suggest to set it in its > > class_init instead if that's a generic bridge function. >=20 > Well, depends on the bridge device. When they have stuff beside core > pci bridge functionality (such as shpc hotplug support like the > 'pci-bridge' device) they need their private function. But those can > still override config_write in the device init I guess. >=20 > /me leaves that to mst to decide. Beside that it should most likely go > into a separate cleanup patch as there are other devices which hook > pci_bridge_write_config the same way. Yea, it's probably not 1.6 material. > > Probably should be for-1.6? >=20 > Yes. >=20 > cheers, > Gerd >=20