From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:39327)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <gabriel@kerneis.info>) id 1V6Qy9-0000gY-Pv
	for qemu-devel@nongnu.org; Mon, 05 Aug 2013 16:01:36 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <gabriel@kerneis.info>) id 1V6Qy4-0004Xi-7v
	for qemu-devel@nongnu.org; Mon, 05 Aug 2013 16:01:29 -0400
Received: from wanbli.kerneis.info ([2001:41d0:8:38ad::1]:45861)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <gabriel@kerneis.info>) id 1V6Qy3-0004Xa-Up
	for qemu-devel@nongnu.org; Mon, 05 Aug 2013 16:01:24 -0400
Date: Mon, 5 Aug 2013 21:01:20 +0100
From: Gabriel Kerneis <gabriel@kerneis.info>
Message-ID: <20130805200120.GC4872@kerneis.info>
References: <1375728247-1306-1-git-send-email-charlie@ctshepherd.com>
	<1375728247-1306-5-git-send-email-charlie@ctshepherd.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <1375728247-1306-5-git-send-email-charlie@ctshepherd.com>
Subject: Re: [Qemu-devel] [PATCH 4/5] Convert block functions to coroutine
	versions
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Charlie Shepherd <charlie@ctshepherd.com>
Cc: kwolf@redhat.com, pbonzini@redhat.com, qemu-devel@nongnu.org, stefanha@gmail.com

On Mon, Aug 05, 2013 at 08:44:06PM +0200, Charlie Shepherd wrote:
> This patch follows on from the previous one and converts some block layer functions to be
> explicitly annotated with coroutine_fn instead of yielding depending upon calling context.

And just like the previous one, it also removes one annotation, which you
might want to mention in the commit message:

> -int coroutine_fn bdrv_co_flush(BlockDriverState *bs)
> +int coroutine_fn bdrv_flush(BlockDriverState *bs)

By the way:

> diff --git a/block.c b/block.c
> index aaa122c..e7011f9 100644
> --- a/block.c
> +++ b/block.c
> @@ -364,7 +364,7 @@ BlockDriver *bdrv_find_whitelisted_format(const char *format_name,
>  
>  typedef struct CreateCo {
>      BlockDriver *drv;
> -    char *filename;
> +    const char *filename;
>      QEMUOptionParameter *options;
>      int ret;
>  } CreateCo;

This looks like an unrelated change which might deserve its own patch.  I'm not
sure what the QEMU policiy is about that kind of minor fix, but maybe send it to
qemu-trivial?

-- 
Gabriel