From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:42187)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <gabriel@kerneis.info>) id 1V6R8U-0006jx-KO
	for qemu-devel@nongnu.org; Mon, 05 Aug 2013 16:12:16 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <gabriel@kerneis.info>) id 1V6R8O-0000E3-T9
	for qemu-devel@nongnu.org; Mon, 05 Aug 2013 16:12:10 -0400
Received: from wanbli.kerneis.info ([2001:41d0:8:38ad::1]:45870)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <gabriel@kerneis.info>) id 1V6R1y-0006LQ-Vv
	for qemu-devel@nongnu.org; Mon, 05 Aug 2013 16:05:27 -0400
Date: Mon, 5 Aug 2013 21:05:24 +0100
From: Gabriel Kerneis <gabriel@kerneis.info>
Message-ID: <20130805200524.GD4872@kerneis.info>
References: <1375728247-1306-1-git-send-email-charlie@ctshepherd.com>
	<1375728247-1306-4-git-send-email-charlie@ctshepherd.com>
	<20130805192347.GB4872@kerneis.info>
	<51FFFDF6.4060602@ctshepherd.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <51FFFDF6.4060602@ctshepherd.com>
Subject: Re: [Qemu-devel] [PATCH 3/5] Convert BlockDriver to explicit
	coroutine annotations
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Charlie Shepherd <charlie@ctshepherd.com>
Cc: kwolf@redhat.com, pbonzini@redhat.com, qemu-devel@nongnu.org, stefanha@gmail.com

On Mon, Aug 05, 2013 at 08:33:10PM +0100, Charlie Shepherd wrote:
> Yes that does merit some explanation.

Thanks for the details.

> qemu_co_queue_run_restart is a bit different. It is only called from
> coroutine_swap in qemu-coroutine.c, and it enters coroutines that
> were waiting but have now moved to the runnable state by the actions
> of the most recent coroutine (I believe). I think we discussed this
> on IRC on Thursday? It only calls qemu_coroutine_enter, and cannot
> yield, so again I removed the annotation. I'll add these
> explanations to the commit message.

Or maybe split those in different commits altogether? I find it often easier to
review many small commits than a big one, each focused on an "atomic" change.

-- 
Gabriel