From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:42999) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1V6RBi-0000BW-EC for qemu-devel@nongnu.org; Mon, 05 Aug 2013 16:15:36 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1V6RBX-0001uK-Rf for qemu-devel@nongnu.org; Mon, 05 Aug 2013 16:15:30 -0400 Received: from wanbli.kerneis.info ([2001:41d0:8:38ad::1]:45888) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1V6RBX-0001tt-Ll for qemu-devel@nongnu.org; Mon, 05 Aug 2013 16:15:19 -0400 Date: Mon, 5 Aug 2013 21:15:16 +0100 From: Gabriel Kerneis Message-ID: <20130805201516.GE4872@kerneis.info> References: <1375728247-1306-1-git-send-email-charlie@ctshepherd.com> <1375728247-1306-6-git-send-email-charlie@ctshepherd.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1375728247-1306-6-git-send-email-charlie@ctshepherd.com> Subject: Re: [Qemu-devel] [PATCH 5/5] Convert block layer callers' annotations List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Charlie Shepherd Cc: kwolf@redhat.com, pbonzini@redhat.com, qemu-devel@nongnu.org, stefanha@gmail.com On Mon, Aug 05, 2013 at 08:44:07PM +0200, Charlie Shepherd wrote: > This patch updates the callers of block layer functions converted to explicit > coroutine_fn annotation in the previous patch. It looks like this patch is made of three parts: - updating the annotations, following the rule "caller of coroutine_fn must be coroutine_fn", - introducing a run_handler function in qemu-img.c, - replacing bdrv_* by bdrv_*_sync in qemu-io-cmds.c. The first one is purely mechanical and boring. The second one is moderately inventive (note that I did not review the code in detail). The third one is simple but definitely deserves some explanation. Again, I think this could be split in three different patches, with an expanded commit message. Best, -- Gabriel