qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Jeff Cody <jcody@redhat.com>
To: Fam Zheng <famz@redhat.com>
Cc: kwolf@redhat.com, pmatouse@redhat.com, qemu-devel@nongnu.org,
	armbru@redhat.com, stefanha@redhat.com, asias@redhat.com,
	areis@redhat.com
Subject: Re: [Qemu-devel] [PATCH v3 02/10] vmdk: Make VmdkGrainMarker QEMU_PACKED
Date: Mon, 5 Aug 2013 23:24:23 -0400	[thread overview]
Message-ID: <20130806032423.GA11689@localhost.localdomain> (raw)
In-Reply-To: <1375753243-19530-3-git-send-email-famz@redhat.com>

On Tue, Aug 06, 2013 at 09:40:35AM +0800, Fam Zheng wrote:
> For consistency, make this on disk structure QEMU_PACKED.
> 
> Signed-off-by: Fam Zheng <famz@redhat.com>
> ---
>  block/vmdk.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 

I don't think this makes it necessary for a respin, but if you do one
anyway, I would suggest squashing this patch and patch 1 together.

> diff --git a/block/vmdk.c b/block/vmdk.c
> index 8ff43b9..7ebe36b 100644
> --- a/block/vmdk.c
> +++ b/block/vmdk.c
> @@ -131,7 +131,7 @@ typedef struct VmdkGrainMarker {
>      uint64_t lba;
>      uint32_t size;
>      uint8_t  data[0];
> -} VmdkGrainMarker;
> +} QEMU_PACKED VmdkGrainMarker;
>  
>  enum {
>      MARKER_END_OF_STREAM    = 0,
> -- 
> 1.8.3.4
> 

  reply	other threads:[~2013-08-06  3:24 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-08-06  1:40 [Qemu-devel] [PATCH v3 00/10] vmdk: Input validation fixes Fam Zheng
2013-08-06  1:40 ` [Qemu-devel] [PATCH v3 01/10] vmdk: Make VMDK3Header QEMU_PACKED Fam Zheng
2013-08-06  1:40 ` [Qemu-devel] [PATCH v3 02/10] vmdk: Make VmdkGrainMarker QEMU_PACKED Fam Zheng
2013-08-06  3:24   ` Jeff Cody [this message]
2013-08-06  1:40 ` [Qemu-devel] [PATCH v3 03/10] vmdk: use unsigned values for on disk header fields Fam Zheng
2013-08-06  3:30   ` Jeff Cody
2013-08-06  3:42     ` Fam Zheng
2013-08-06  1:40 ` [Qemu-devel] [PATCH v3 04/10] qemu-iotests: add poke_file utility function Fam Zheng
2013-08-06  1:40 ` [Qemu-devel] [PATCH v3 05/10] qemu-iotests: add empty test case for vmdk Fam Zheng
2013-08-06  1:40 ` [Qemu-devel] [PATCH v3 06/10] vmdk: check granularity field in opening Fam Zheng
2013-08-06  1:40 ` [Qemu-devel] [PATCH v3 07/10] vmdk: check l2 table size when opening Fam Zheng
2013-08-06  1:40 ` [Qemu-devel] [PATCH v3 08/10] vmdk: check l1 size before opening image Fam Zheng
2013-08-06  1:40 ` [Qemu-devel] [PATCH v3 09/10] vmdk: use heap allocation for whole_grain Fam Zheng
2013-08-06  3:52   ` Jeff Cody
2013-08-06  1:40 ` [Qemu-devel] [PATCH v3 10/10] vmdk: rename num_gtes_per_gte to num_gtes_per_gt Fam Zheng
2013-08-06  3:54   ` Jeff Cody
2013-08-06  7:53 ` [Qemu-devel] [PATCH v3 00/10] vmdk: Input validation fixes Stefan Hajnoczi

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20130806032423.GA11689@localhost.localdomain \
    --to=jcody@redhat.com \
    --cc=areis@redhat.com \
    --cc=armbru@redhat.com \
    --cc=asias@redhat.com \
    --cc=famz@redhat.com \
    --cc=kwolf@redhat.com \
    --cc=pmatouse@redhat.com \
    --cc=qemu-devel@nongnu.org \
    --cc=stefanha@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).