From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:46338) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1V6YAx-0005I1-0c for qemu-devel@nongnu.org; Mon, 05 Aug 2013 23:43:16 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1V6YAq-0007UK-GA for qemu-devel@nongnu.org; Mon, 05 Aug 2013 23:43:10 -0400 Received: from mx1.redhat.com ([209.132.183.28]:33235) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1V6YAq-0007U4-8g for qemu-devel@nongnu.org; Mon, 05 Aug 2013 23:43:04 -0400 Received: from int-mx10.intmail.prod.int.phx2.redhat.com (int-mx10.intmail.prod.int.phx2.redhat.com [10.5.11.23]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id r763h202024411 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Mon, 5 Aug 2013 23:43:03 -0400 Date: Tue, 6 Aug 2013 11:42:47 +0800 From: Fam Zheng Message-ID: <20130806034247.GA30908@T430s.nay.redhat.com> References: <1375753243-19530-1-git-send-email-famz@redhat.com> <1375753243-19530-4-git-send-email-famz@redhat.com> <20130806033054.GA12136@localhost.localdomain> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20130806033054.GA12136@localhost.localdomain> Subject: Re: [Qemu-devel] [PATCH v3 03/10] vmdk: use unsigned values for on disk header fields Reply-To: famz@redhat.com List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Jeff Cody Cc: kwolf@redhat.com, pmatouse@redhat.com, qemu-devel@nongnu.org, armbru@redhat.com, stefanha@redhat.com, asias@redhat.com, areis@redhat.com On Mon, 08/05 23:30, Jeff Cody wrote: > On Tue, Aug 06, 2013 at 09:40:36AM +0800, Fam Zheng wrote: > > The size and offset fields are all non-negative values, use uint64_t for > > them to avoid getting negative in memory value by int overflow. > > > > Signed-off-by: Fam Zheng > > --- > > block/vmdk.c | 16 ++++++++-------- > > 1 file changed, 8 insertions(+), 8 deletions(-) > > > > diff --git a/block/vmdk.c b/block/vmdk.c > > index 7ebe36b..976b871 100644 > > --- a/block/vmdk.c > > +++ b/block/vmdk.c > > @@ -67,14 +67,14 @@ typedef struct { > > typedef struct { > > uint32_t version; > > uint32_t flags; > > - int64_t capacity; > > - int64_t granularity; > > - int64_t desc_offset; > > - int64_t desc_size; > > - int32_t num_gtes_per_gte; > > - int64_t rgd_offset; > > - int64_t gd_offset; > > - int64_t grain_offset; > > + uint64_t capacity; > > + uint64_t granularity; > > + uint64_t desc_offset; > > desc_offset in BDRVVmdkState should be uint64_t as well, right? Yes, will fix. > > > + uint64_t desc_size; > > + uint32_t num_gtes_per_gte; > > + uint64_t rgd_offset; > > + uint64_t gd_offset; > > + uint64_t grain_offset; > > char filler[1]; > > char check_bytes[4]; > > uint16_t compressAlgorithm; > > -- > > 1.8.3.4 > > -- Fam