From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:51345)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <namei.unix@gmail.com>) id 1V6b9q-0003bT-6F
	for qemu-devel@nongnu.org; Tue, 06 Aug 2013 02:54:23 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <namei.unix@gmail.com>) id 1V6b9h-0001UR-PN
	for qemu-devel@nongnu.org; Tue, 06 Aug 2013 02:54:14 -0400
Received: from mail-pd0-x22f.google.com ([2607:f8b0:400e:c02::22f]:42848)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <namei.unix@gmail.com>) id 1V6b9h-0001UM-Ik
	for qemu-devel@nongnu.org; Tue, 06 Aug 2013 02:54:05 -0400
Received: by mail-pd0-f175.google.com with SMTP id 5so12120pdd.20
	for <qemu-devel@nongnu.org>; Mon, 05 Aug 2013 23:54:04 -0700 (PDT)
Date: Tue, 6 Aug 2013 14:53:58 +0800
From: Liu Yuan <namei.unix@gmail.com>
Message-ID: <20130806065358.GA14081@ubuntu-precise>
References: <1375771477-14277-1-git-send-email-namei.unix@gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <1375771477-14277-1-git-send-email-namei.unix@gmail.com>
Subject: Re: [Qemu-devel] [PATCH] sheepdog: add missing .bdrv_has_zero_init
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: qemu-devel@nongnu.org
Cc: Kevin Wolf <kwolf@redhat.com>, sheepdog@lists.wpkg.org, Stefan Hajnoczi <stefanha@redhat.com>

On Tue, Aug 06, 2013 at 02:44:37PM +0800, Liu Yuan wrote:
> Cc: Kevin Wolf <kwolf@redhat.com>
> Cc: Stefan Hajnoczi <stefanha@redhat.com>
> Signed-off-by: Liu Yuan <namei.unix@gmail.com>
> ---
>  block/sheepdog.c |    2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/block/sheepdog.c b/block/sheepdog.c
> index 46821df..eeb5617 100644
> --- a/block/sheepdog.c
> +++ b/block/sheepdog.c
> @@ -2421,6 +2421,7 @@ static BlockDriver bdrv_sheepdog = {
>      .bdrv_file_open = sd_open,
>      .bdrv_close     = sd_close,
>      .bdrv_create    = sd_create,
> +    .bdrv_has_zero_init = bdrv_has_zero_init_1,
>      .bdrv_getlength = sd_getlength,
>      .bdrv_truncate  = sd_truncate,
>  
> @@ -2448,6 +2449,7 @@ static BlockDriver bdrv_sheepdog_tcp = {
>      .bdrv_file_open = sd_open,
>      .bdrv_close     = sd_close,
>      .bdrv_create    = sd_create,
> +    .bdrv_has_zero_init = bdrv_has_zero_init_1,
>      .bdrv_getlength = sd_getlength,
>      .bdrv_truncate  = sd_truncate,
>  

This patch should go for v1.6 too, because qemu-img won't create expected sparse
images for sheepdog without this patch.

Thanks
Yuan