From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:37046)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <stefanha@redhat.com>) id 1V6c5W-0007D9-Rv
	for qemu-devel@nongnu.org; Tue, 06 Aug 2013 03:53:56 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <stefanha@redhat.com>) id 1V6c5Q-0007Yh-Ss
	for qemu-devel@nongnu.org; Tue, 06 Aug 2013 03:53:50 -0400
Received: from mx1.redhat.com ([209.132.183.28]:18182)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <stefanha@redhat.com>) id 1V6c5Q-0007YU-Kn
	for qemu-devel@nongnu.org; Tue, 06 Aug 2013 03:53:44 -0400
Received: from int-mx11.intmail.prod.int.phx2.redhat.com
	(int-mx11.intmail.prod.int.phx2.redhat.com [10.5.11.24])
	by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id r767rhT8004084
	(version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK)
	for <qemu-devel@nongnu.org>; Tue, 6 Aug 2013 03:53:43 -0400
Date: Tue, 6 Aug 2013 09:53:41 +0200
From: Stefan Hajnoczi <stefanha@redhat.com>
Message-ID: <20130806075341.GB27705@stefanha-thinkpad.redhat.com>
References: <1375753243-19530-1-git-send-email-famz@redhat.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <1375753243-19530-1-git-send-email-famz@redhat.com>
Subject: Re: [Qemu-devel] [PATCH v3 00/10] vmdk: Input validation fixes
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Fam Zheng <famz@redhat.com>
Cc: kwolf@redhat.com, pmatouse@redhat.com, jcody@redhat.com, qemu-devel@nongnu.org, armbru@redhat.com, asias@redhat.com, areis@redhat.com

On Tue, Aug 06, 2013 at 09:40:33AM +0800, Fam Zheng wrote:
> Fixes for VMDK sparse file opening. Header fields are checked before used for
> memory allocation.
> 
> v3:
>     00: Rebase to master.
>     04: Drop unused line in test script.
>     05: change vmdk_add_extent signature (uint64_t cluster_sectors).
>     06: Fix num_gtes_per_gte.
>     08: Use qemu_blockalign for whole_grain.
>         Don't allocate memory for !bs->backing_hd case.
> 
> Fam Zheng (9):
>   vmdk: Make VMDK3Header QEMU_PACKED
>   vmdk: Make VmdkGrainMarker QEMU_PACKED
>   vmdk: use unsigned values for on disk header fields
>   qemu-iotests: add empty test case for vmdk
>   vmdk: check granularity field in opening
>   vmdk: check l2 table size when opening
>   vmdk: check l1 size before opening image
>   vmdk: use heap allocation for whole_grain
>   vmdk: rename num_gtes_per_gte to num_gtes_per_gt
> 
> Stefan Hajnoczi (1):
>   qemu-iotests: add poke_file utility function
> 
>  block/vmdk.c                 | 104 ++++++++++++++++++++++++++++++-------------
>  tests/qemu-iotests/059       |  72 ++++++++++++++++++++++++++++++
>  tests/qemu-iotests/059.out   |  20 +++++++++
>  tests/qemu-iotests/common.rc |   6 +++
>  tests/qemu-iotests/group     |   1 +
>  5 files changed, 172 insertions(+), 31 deletions(-)
>  create mode 100755 tests/qemu-iotests/059
>  create mode 100644 tests/qemu-iotests/059.out

I'm happy now modulo Jeff's comments.