qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Kevin Wolf <kwolf@redhat.com>
To: MORITA Kazutaka <morita.kazutaka@lab.ntt.co.jp>
Cc: Liu Yuan <namei.unix@gmail.com>,
	sheepdog@lists.wpkg.org, qemu-devel@nongnu.org,
	Stefan Hajnoczi <stefanha@redhat.com>
Subject: Re: [Qemu-devel] [sheepdog] [PATCH] sheepdog: add missing .bdrv_has_zero_init
Date: Tue, 6 Aug 2013 10:24:42 +0200	[thread overview]
Message-ID: <20130806082442.GA3117@dhcp-200-207.str.redhat.com> (raw)
In-Reply-To: <87y58ftgls.wl%morita.kazutaka@lab.ntt.co.jp>

Am 06.08.2013 um 09:37 hat MORITA Kazutaka geschrieben:
> At Tue,  6 Aug 2013 14:44:37 +0800,
> Liu Yuan wrote:
> > 
> > Cc: Kevin Wolf <kwolf@redhat.com>
> > Cc: Stefan Hajnoczi <stefanha@redhat.com>
> > Signed-off-by: Liu Yuan <namei.unix@gmail.com>
> > ---
> >  block/sheepdog.c |    2 ++
> >  1 file changed, 2 insertions(+)
> 
> Reviewed-by: MORITA Kazutaka <morita.kazutaka@lab.ntt.co.jp>

The commit message is lacking. Added this description:

    Commit 3ac21627 changed the behaviour of bdrv_has_zero_init() to default
    to 0. In the review for Sheepdog it turned out that enabling it is safe,
    so that commit updated one BlockDriver definition of sheepdog to use
    bdrv_has_zero_init_1, missed however that there are more BlockDrivers in
    the driver. Fix these now.

And applied the patch to the block branch.

Kevin

  reply	other threads:[~2013-08-06  8:25 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-08-06  6:44 [Qemu-devel] [PATCH] sheepdog: add missing .bdrv_has_zero_init Liu Yuan
2013-08-06  6:53 ` Liu Yuan
2013-08-06  7:37 ` [Qemu-devel] [sheepdog] " MORITA Kazutaka
2013-08-06  8:24   ` Kevin Wolf [this message]
2013-08-06  8:37     ` Liu Yuan

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20130806082442.GA3117@dhcp-200-207.str.redhat.com \
    --to=kwolf@redhat.com \
    --cc=morita.kazutaka@lab.ntt.co.jp \
    --cc=namei.unix@gmail.com \
    --cc=qemu-devel@nongnu.org \
    --cc=sheepdog@lists.wpkg.org \
    --cc=stefanha@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).