From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:43734)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <kwolf@redhat.com>) id 1V6cZl-0004bA-4s
	for qemu-devel@nongnu.org; Tue, 06 Aug 2013 04:25:10 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <kwolf@redhat.com>) id 1V6cZg-0002XQ-5J
	for qemu-devel@nongnu.org; Tue, 06 Aug 2013 04:25:05 -0400
Received: from mx1.redhat.com ([209.132.183.28]:27529)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <kwolf@redhat.com>) id 1V6cZf-0002X9-Mq
	for qemu-devel@nongnu.org; Tue, 06 Aug 2013 04:25:00 -0400
Date: Tue, 6 Aug 2013 10:24:42 +0200
From: Kevin Wolf <kwolf@redhat.com>
Message-ID: <20130806082442.GA3117@dhcp-200-207.str.redhat.com>
References: <1375771477-14277-1-git-send-email-namei.unix@gmail.com>
	<87y58ftgls.wl%morita.kazutaka@lab.ntt.co.jp>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <87y58ftgls.wl%morita.kazutaka@lab.ntt.co.jp>
Subject: Re: [Qemu-devel] [sheepdog] [PATCH] sheepdog: add missing
	.bdrv_has_zero_init
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: MORITA Kazutaka <morita.kazutaka@lab.ntt.co.jp>
Cc: Liu Yuan <namei.unix@gmail.com>, sheepdog@lists.wpkg.org, qemu-devel@nongnu.org, Stefan Hajnoczi <stefanha@redhat.com>

Am 06.08.2013 um 09:37 hat MORITA Kazutaka geschrieben:
> At Tue,  6 Aug 2013 14:44:37 +0800,
> Liu Yuan wrote:
> > 
> > Cc: Kevin Wolf <kwolf@redhat.com>
> > Cc: Stefan Hajnoczi <stefanha@redhat.com>
> > Signed-off-by: Liu Yuan <namei.unix@gmail.com>
> > ---
> >  block/sheepdog.c |    2 ++
> >  1 file changed, 2 insertions(+)
> 
> Reviewed-by: MORITA Kazutaka <morita.kazutaka@lab.ntt.co.jp>

The commit message is lacking. Added this description:

    Commit 3ac21627 changed the behaviour of bdrv_has_zero_init() to default
    to 0. In the review for Sheepdog it turned out that enabling it is safe,
    so that commit updated one BlockDriver definition of sheepdog to use
    bdrv_has_zero_init_1, missed however that there are more BlockDrivers in
    the driver. Fix these now.

And applied the patch to the block branch.

Kevin