From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:46853) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1V6cks-00024R-GA for qemu-devel@nongnu.org; Tue, 06 Aug 2013 04:36:41 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1V6ckm-00075F-3Z for qemu-devel@nongnu.org; Tue, 06 Aug 2013 04:36:34 -0400 Received: from mx1.redhat.com ([209.132.183.28]:21483) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1V6ckl-000756-RT for qemu-devel@nongnu.org; Tue, 06 Aug 2013 04:36:28 -0400 Date: Tue, 6 Aug 2013 11:36:25 +0300 From: Gleb Natapov Message-ID: <20130806083625.GF8218@redhat.com> References: <20130805081617.GB2258@redhat.com> <51FF6A79.9060603@redhat.com> <703333176.9515483.1375697447963.JavaMail.root@redhat.com> <20130805151723.GF877@redhat.com> <1970367422.9695773.1375718517492.JavaMail.root@redhat.com> <20130805161833.GA4244@redhat.com> <51FFD6CE.5090302@redhat.com> <20130805182628.GC4244@redhat.com> <20130806072152.GK10891@redhat.com> <20130806083309.GA11051@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20130806083309.GA11051@redhat.com> Subject: Re: [Qemu-devel] [SeaBIOS] [PATCH] don't expose pvpanic device in the UI List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: "Michael S. Tsirkin" Cc: Marcel Apfelbaum , seabios@seabios.org, qemu-devel@nongnu.org, Gerd Hoffmann , Paolo Bonzini , Andreas =?utf-8?Q?F=C3=A4rber?= On Tue, Aug 06, 2013 at 11:33:10AM +0300, Michael S. Tsirkin wrote: > On Tue, Aug 06, 2013 at 10:21:52AM +0300, Gleb Natapov wrote: > > > If you see a mouse in a room, how likely is it that there's > > > a single mouse there? > > > > > > This is a PV technology which to me looks like it was > > > rushed through and not only set on by default, but > > > without a way to disable it - apparently on the assumption > > > there's 0 chance it can cause any damage. Now that > > > we do know the chance it's not there, why not go back > > > to the standard interface, and why not give > > > users a chance to enable/disable it? > > You should be able to disable it with: -device pvpanic,ioport=0 > > Doesn't work for me. Bug that should be fixed. With this command line _STA should return zero. > Besides, both -device pvpanic and use of ioport=0 to disable it > are completely undocumented. > Not the only undocumented thing in QEMU command line :) > BTW pls keep qemu-devel Cc'd. > Haven't touched CC list. > > We have different definition of "damage" though. > > Driver bugs, qemu bugs, OSPM bugs all can cause issues > like OS crashes, suspend/resume issues, bad > performance ... What's your definition of damage? > None of those cover the case at hand. -- Gleb.