From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:47156) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1V6cm0-00032p-MR for qemu-devel@nongnu.org; Tue, 06 Aug 2013 04:37:50 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1V6cls-0007Nl-JC for qemu-devel@nongnu.org; Tue, 06 Aug 2013 04:37:44 -0400 Received: from mail-pb0-x236.google.com ([2607:f8b0:400e:c01::236]:37373) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1V6cls-0007NS-CX for qemu-devel@nongnu.org; Tue, 06 Aug 2013 04:37:36 -0400 Received: by mail-pb0-f54.google.com with SMTP id ro12so114215pbb.41 for ; Tue, 06 Aug 2013 01:37:35 -0700 (PDT) Date: Tue, 6 Aug 2013 16:37:27 +0800 From: Liu Yuan Message-ID: <20130806083727.GB14081@ubuntu-precise> References: <1375771477-14277-1-git-send-email-namei.unix@gmail.com> <87y58ftgls.wl%morita.kazutaka@lab.ntt.co.jp> <20130806082442.GA3117@dhcp-200-207.str.redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20130806082442.GA3117@dhcp-200-207.str.redhat.com> Subject: Re: [Qemu-devel] [sheepdog] [PATCH] sheepdog: add missing .bdrv_has_zero_init List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Kevin Wolf Cc: Stefan Hajnoczi , sheepdog@lists.wpkg.org, qemu-devel@nongnu.org, MORITA Kazutaka On Tue, Aug 06, 2013 at 10:24:42AM +0200, Kevin Wolf wrote: > Am 06.08.2013 um 09:37 hat MORITA Kazutaka geschrieben: > > At Tue, 6 Aug 2013 14:44:37 +0800, > > Liu Yuan wrote: > > > > > > Cc: Kevin Wolf > > > Cc: Stefan Hajnoczi > > > Signed-off-by: Liu Yuan > > > --- > > > block/sheepdog.c | 2 ++ > > > 1 file changed, 2 insertions(+) > > > > Reviewed-by: MORITA Kazutaka > > The commit message is lacking. Added this description: > > Commit 3ac21627 changed the behaviour of bdrv_has_zero_init() to default > to 0. In the review for Sheepdog it turned out that enabling it is safe, > so that commit updated one BlockDriver definition of sheepdog to use > bdrv_has_zero_init_1, missed however that there are more BlockDrivers in > the driver. Fix these now. > > And applied the patch to the block branch. Thanks for your detailed commit log, I should have done it. Yuan