From: Fam Zheng <famz@redhat.com>
To: "Benoît Canet" <benoit@irqsave.net>
Cc: kwolf@redhat.com, pbonzini@redhat.com, qemu-devel@nongnu.org,
stefanha@redhat.com
Subject: Re: [Qemu-devel] [RFC V3 0/2] continuous leaky bucket throttling
Date: Tue, 6 Aug 2013 17:22:05 +0800 [thread overview]
Message-ID: <20130806092205.GA24514@T430s.nay.redhat.com> (raw)
In-Reply-To: <1375458782-14888-1-git-send-email-benoit@irqsave.net>
On Fri, 08/02 17:53, Benoît Canet wrote:
> This patchset implement continous leaky bucket throttling.
>
> It works mostly on the general case.
> The exception is where the load is composed of both reads and writes and two
> limits iops_rd and iops_wr are set.
> The resulting iops are a little above half of the given limits.
> I tried various strategies to avoid this: two timer, two throttled request
> queues or even a different algorithm using a priority queue.
> The problem is still the same in every version of the code: reads and writes
> operation seems entangled.
>
> Benoît Canet (2):
> throttle: Add a new throttling API implementing continuus leaky
s/continuus/continuous/
> bucket.
> block: Enable the new throttling code in the block layer.
>
> block.c | 316 ++++++++------------------------
> block/qapi.c | 21 +--
> blockdev.c | 115 ++++++------
> include/block/block.h | 1 -
> include/block/block_int.h | 33 +---
> include/qemu/throttle.h | 111 ++++++++++++
> util/Makefile.objs | 1 +
> util/throttle.c | 436 +++++++++++++++++++++++++++++++++++++++++++++
> 8 files changed, 698 insertions(+), 336 deletions(-)
> create mode 100644 include/qemu/throttle.h
> create mode 100644 util/throttle.c
>
> --
> 1.7.10.4
>
>
--
Fam
next prev parent reply other threads:[~2013-08-06 9:22 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-08-02 15:53 [Qemu-devel] [RFC V3 0/2] continuous leaky bucket throttling Benoît Canet
2013-08-02 15:53 ` [Qemu-devel] [RFC V3 1/2] throttle: Add a new throttling API implementing continuus leaky bucket Benoît Canet
2013-08-02 15:53 ` [Qemu-devel] [RFC V3 2/2] block: Enable the new throttling code in the block layer Benoît Canet
2013-08-06 9:22 ` Fam Zheng [this message]
2013-08-07 8:31 ` [Qemu-devel] [RFC V3 0/2] continuous leaky bucket throttling Stefan Hajnoczi
2013-08-07 21:23 ` Benoît Canet
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130806092205.GA24514@T430s.nay.redhat.com \
--to=famz@redhat.com \
--cc=benoit@irqsave.net \
--cc=kwolf@redhat.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=stefanha@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).