From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:43131)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <gleb@redhat.com>) id 1V6eHZ-0000Qd-Ir
	for qemu-devel@nongnu.org; Tue, 06 Aug 2013 06:14:31 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <gleb@redhat.com>) id 1V6eHT-0004Tw-KS
	for qemu-devel@nongnu.org; Tue, 06 Aug 2013 06:14:25 -0400
Received: from mx1.redhat.com ([209.132.183.28]:5116)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <gleb@redhat.com>) id 1V6eHT-0004Sy-CQ
	for qemu-devel@nongnu.org; Tue, 06 Aug 2013 06:14:19 -0400
Date: Tue, 6 Aug 2013 13:14:14 +0300
From: Gleb Natapov <gleb@redhat.com>
Message-ID: <20130806101414.GO8218@redhat.com>
References: <20130805151723.GF877@redhat.com>
	<1970367422.9695773.1375718517492.JavaMail.root@redhat.com>
	<20130805161833.GA4244@redhat.com> <51FFD6CE.5090302@redhat.com>
	<20130805182628.GC4244@redhat.com>
	<20130806072152.GK10891@redhat.com>
	<20130806083309.GA11051@redhat.com>
	<20130806092646.GC6433@localhost.localdomain>
	<20130806092927.GA12514@redhat.com>
	<20130806101317.GB13680@redhat.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20130806101317.GB13680@redhat.com>
Subject: Re: [Qemu-devel] [SeaBIOS] [PATCH] don't expose pvpanic device in
	the UI
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: "Michael S. Tsirkin" <mst@redhat.com>
Cc: Marcel Apfelbaum <marcel.a@redhat.com>, Hu Tao <hutao@cn.fujitsu.com>, seabios@seabios.org, qemu-devel@nongnu.org, Gerd Hoffmann <kraxel@redhat.com>, Paolo Bonzini <pbonzini@redhat.com>, Andreas =?utf-8?Q?F=C3=A4rber?= <afaerber@suse.de>

On Tue, Aug 06, 2013 at 01:13:17PM +0300, Michael S. Tsirkin wrote:
> On Tue, Aug 06, 2013 at 12:29:27PM +0300, Gleb Natapov wrote:
> > On Tue, Aug 06, 2013 at 05:26:46PM +0800, Hu Tao wrote:
> > > On Tue, Aug 06, 2013 at 11:33:10AM +0300, Michael S. Tsirkin wrote:
> > > > On Tue, Aug 06, 2013 at 10:21:52AM +0300, Gleb Natapov wrote:
> > > > > > If you see a mouse in a room, how likely is it that there's
> > > > > > a single mouse there?
> > > > > > 
> > > > > > This is a PV technology which to me looks like it was
> > > > > > rushed through and not only set on by default, but
> > > > > > without a way to disable it - apparently on the assumption
> > > > > > there's 0 chance it can cause any damage. Now that
> > > > > > we do know the chance it's not there, why not go back
> > > > > > to the standard interface, and why not give
> > > > > > users a chance to enable/disable it?
> > > > > You should be able to disable it with: -device pvpanic,ioport=0
> > > > 
> > > > Doesn't work for me.
> > > 
> > > The internal pvpanic can be disabled by -global pvpanic.ioport=0.
> > > -device pvpanic,ioport=0 just adds another pvpanic device.
> > Yeah, good point.
> 
> I tried this, this doesn't remove the device - merely sets the
> port to 0.
> 
That's the point. And _STA will report it as disabled. You asked if the device
can be enable/disable above, not removed. It can.

--
			Gleb.