From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:44429) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1V6eOy-0004OF-3F for qemu-devel@nongnu.org; Tue, 06 Aug 2013 06:22:10 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1V6eOq-0007BX-NY for qemu-devel@nongnu.org; Tue, 06 Aug 2013 06:22:04 -0400 Received: from mx1.redhat.com ([209.132.183.28]:45878) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1V6eOq-0007BQ-ER for qemu-devel@nongnu.org; Tue, 06 Aug 2013 06:21:56 -0400 Date: Tue, 6 Aug 2013 13:23:26 +0300 From: "Michael S. Tsirkin" Message-ID: <20130806102326.GD13680@redhat.com> References: <1970367422.9695773.1375718517492.JavaMail.root@redhat.com> <20130805161833.GA4244@redhat.com> <51FFD6CE.5090302@redhat.com> <20130805182628.GC4244@redhat.com> <20130806072152.GK10891@redhat.com> <20130806083309.GA11051@redhat.com> <20130806092646.GC6433@localhost.localdomain> <20130806092927.GA12514@redhat.com> <20130806101317.GB13680@redhat.com> <20130806101414.GO8218@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20130806101414.GO8218@redhat.com> Subject: Re: [Qemu-devel] [SeaBIOS] [PATCH] don't expose pvpanic device in the UI List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Gleb Natapov Cc: Marcel Apfelbaum , Hu Tao , seabios@seabios.org, qemu-devel@nongnu.org, Gerd Hoffmann , Paolo Bonzini , Andreas =?iso-8859-1?Q?F=E4rber?= On Tue, Aug 06, 2013 at 01:14:14PM +0300, Gleb Natapov wrote: > On Tue, Aug 06, 2013 at 01:13:17PM +0300, Michael S. Tsirkin wrote: > > On Tue, Aug 06, 2013 at 12:29:27PM +0300, Gleb Natapov wrote: > > > On Tue, Aug 06, 2013 at 05:26:46PM +0800, Hu Tao wrote: > > > > On Tue, Aug 06, 2013 at 11:33:10AM +0300, Michael S. Tsirkin wrote: > > > > > On Tue, Aug 06, 2013 at 10:21:52AM +0300, Gleb Natapov wrote: > > > > > > > If you see a mouse in a room, how likely is it that there's > > > > > > > a single mouse there? > > > > > > > > > > > > > > This is a PV technology which to me looks like it was > > > > > > > rushed through and not only set on by default, but > > > > > > > without a way to disable it - apparently on the assumption > > > > > > > there's 0 chance it can cause any damage. Now that > > > > > > > we do know the chance it's not there, why not go back > > > > > > > to the standard interface, and why not give > > > > > > > users a chance to enable/disable it? > > > > > > You should be able to disable it with: -device pvpanic,ioport=0 > > > > > > > > > > Doesn't work for me. > > > > > > > > The internal pvpanic can be disabled by -global pvpanic.ioport=0. > > > > -device pvpanic,ioport=0 just adds another pvpanic device. > > > Yeah, good point. > > > > I tried this, this doesn't remove the device - merely sets the > > port to 0. > > > That's the point. And _STA will report it as disabled. In ACPI? Why have it at all? > You asked if the device > can be enable/disable above, not removed. It can. I really meant QOM/QMP. _STA is only seen by OSPM. > -- > Gleb.