From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:34995)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <stefanha@gmail.com>) id 1V6fkS-0001TH-0N
	for qemu-devel@nongnu.org; Tue, 06 Aug 2013 07:48:28 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <stefanha@gmail.com>) id 1V6fkJ-0007Qw-Jq
	for qemu-devel@nongnu.org; Tue, 06 Aug 2013 07:48:19 -0400
Received: from mail-wg0-x231.google.com ([2a00:1450:400c:c00::231]:45312)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <stefanha@gmail.com>) id 1V6fkJ-0007QP-EC
	for qemu-devel@nongnu.org; Tue, 06 Aug 2013 07:48:11 -0400
Received: by mail-wg0-f49.google.com with SMTP id y10so254235wgg.4
	for <qemu-devel@nongnu.org>; Tue, 06 Aug 2013 04:48:10 -0700 (PDT)
Date: Tue, 6 Aug 2013 13:48:06 +0200
From: Stefan Hajnoczi <stefanha@gmail.com>
Message-ID: <20130806114806.GB7439@stefanha-thinkpad.redhat.com>
References: <714109BBB1F743A30290732C@nimrod.local>
	<1375639805-1943-1-git-send-email-alex@alex.org.uk>
	<1375639805-1943-7-git-send-email-alex@alex.org.uk>
	<20130806101017.GA7439@stefanha-thinkpad.redhat.com>
	<DCF9C64E8389F862A0251C04@nimrod.local>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <DCF9C64E8389F862A0251C04@nimrod.local>
Subject: Re: [Qemu-devel] [RFC] [PATCHv5 06/16] aio / timers: Untangle
 include files
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Alex Bligh <alex@alex.org.uk>
Cc: Kevin Wolf <kwolf@redhat.com>, Anthony Liguori <aliguori@us.ibm.com>, qemu-devel@nongnu.org, liu ping fan <qemulist@gmail.com>, Stefan Hajnoczi <stefanha@redhat.com>, Paolo Bonzini <pbonzini@redhat.com>, MORITA Kazutaka <morita.kazutaka@lab.ntt.co.jp>, rth@twiddle.net

On Tue, Aug 06, 2013 at 12:20:31PM +0100, Alex Bligh wrote:
> Is this untangling include files approach a good one? Most of the functions
> that these things needed appeared to have little to do with main-loop
> per se. (though they are in main-loop.c).

I'm happy with it since qemu_set_fd_handler2() is indeed a main-loop
function.

Stefan