From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:48079)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <stefanha@redhat.com>) id 1V6gSt-0004Hs-U1
	for qemu-devel@nongnu.org; Tue, 06 Aug 2013 08:34:22 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <stefanha@redhat.com>) id 1V6gSo-000237-Ty
	for qemu-devel@nongnu.org; Tue, 06 Aug 2013 08:34:15 -0400
Received: from mx1.redhat.com ([209.132.183.28]:37698)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <stefanha@redhat.com>) id 1V6gSo-000230-Mj
	for qemu-devel@nongnu.org; Tue, 06 Aug 2013 08:34:10 -0400
Date: Tue, 6 Aug 2013 14:34:00 +0200
From: Stefan Hajnoczi <stefanha@redhat.com>
Message-ID: <20130806123400.GE30812@stefanha-thinkpad.redhat.com>
References: <1375639805-1943-1-git-send-email-alex@alex.org.uk>
	<1375780592-22842-1-git-send-email-alex@alex.org.uk>
	<1375780592-22842-10-git-send-email-alex@alex.org.uk>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <1375780592-22842-10-git-send-email-alex@alex.org.uk>
Subject: Re: [Qemu-devel] [RFC] [PATCHv6 09/16] aio / timers: Add a notify
 callback to QEMUTimerList
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Alex Bligh <alex@alex.org.uk>
Cc: Kevin Wolf <kwolf@redhat.com>, Anthony Liguori <aliguori@us.ibm.com>, qemu-devel@nongnu.org, liu ping fan <qemulist@gmail.com>, Paolo Bonzini <pbonzini@redhat.com>, MORITA Kazutaka <morita.kazutaka@lab.ntt.co.jp>, rth@twiddle.net

On Tue, Aug 06, 2013 at 10:16:25AM +0100, Alex Bligh wrote:
> Add a notify pointer to QEMUTimerList so it knows what to notify
> on a timer change.
> 
> Signed-off-by: Alex Bligh <alex@alex.org.uk>
> ---
>  async.c              |    7 ++++++-
>  include/qemu/timer.h |    7 ++++++-
>  qemu-timer.c         |   24 ++++++++++++++++++++++--
>  3 files changed, 34 insertions(+), 4 deletions(-)
> 
> diff --git a/async.c b/async.c
> index 99fb5a8..8daa232 100644
> --- a/async.c
> +++ b/async.c
> @@ -234,6 +234,11 @@ void aio_notify(AioContext *ctx)
>      event_notifier_set(&ctx->notifier);
>  }
>  
> +static void aio_timerlist_notify(void *opaque)
> +{
> +    aio_notify((AioContext *)opaque);

void * is automatically converted to any pointer type.  No need for an
explicit cast, a C compiler doesn't emit a warning here.