From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:49314)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <stefanha@gmail.com>) id 1V6yDz-0003mC-2v
	for qemu-devel@nongnu.org; Wed, 07 Aug 2013 03:32:08 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <stefanha@gmail.com>) id 1V6yDt-0007Dp-6u
	for qemu-devel@nongnu.org; Wed, 07 Aug 2013 03:32:02 -0400
Date: Wed, 7 Aug 2013 09:31:41 +0200
From: Stefan Hajnoczi <stefanha@gmail.com>
Message-ID: <20130807073141.GE19825@stefanha-thinkpad.redhat.com>
References: <1374765505-14356-1-git-send-email-stefanha@redhat.com>
	<1374765505-14356-2-git-send-email-stefanha@redhat.com>
	<51F21AA0.3090406@linux.vnet.ibm.com>
	<20130806150621.GA9327@stefanha-thinkpad.redhat.com>
	<5201B412.7010801@linux.vnet.ibm.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <5201B412.7010801@linux.vnet.ibm.com>
Subject: Re: [Qemu-devel] [PATCH v6 01/18] block: ensure bdrv_drain_all()
 works during bdrv_delete()
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Wenchao Xia <xiawenc@linux.vnet.ibm.com>
Cc: Kevin Wolf <kwolf@redhat.com>, Ping Fan Liu <pingfank@linux.vnet.ibm.com>, Stefan Hajnoczi <stefanha@redhat.com>, qemu-devel@nongnu.org, Michael Roth <mdroth@linux.vnet.ibm.com>, qemu-stable@nongnu.org, alex@alex.org.uk, Paolo Bonzini <pbonzini@redhat.com>

On Wed, Aug 07, 2013 at 10:42:26AM +0800, Wenchao Xia wrote:
> >On Fri, Jul 26, 2013 at 02:43:44PM +0800, Wenchao Xia wrote:
> >>Reviewed-by: Wenchao Xia <xiawenc@linux.vnet.ibm.com>
> >>
> >>One question: old code missed itself in bdrv_drain_all(), is that a bug?
> >
> >Sorry, I don't understand the question.  Can you rephrase it?
> >
>   Before this patch, in the code path: bdrv_close()->bdrv_drain_all(),
> the *bs does not exist in bdrv_states, so the code missed the chance to
> drain the request on *bs. That is a bug, and this patch is actually a
> bugfix?

Yes, exactly.  It's a bug fix and therefore I CCed
qemu-stable@nongnu.org.

Stefan