From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:34927)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <stefanha@gmail.com>) id 1V71xU-0001Lz-Lm
	for qemu-devel@nongnu.org; Wed, 07 Aug 2013 07:31:22 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <stefanha@gmail.com>) id 1V71xO-0007Wn-Ry
	for qemu-devel@nongnu.org; Wed, 07 Aug 2013 07:31:16 -0400
Received: from mail-ea0-x235.google.com ([2a00:1450:4013:c01::235]:51715)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <stefanha@gmail.com>) id 1V71xO-0007We-Lm
	for qemu-devel@nongnu.org; Wed, 07 Aug 2013 07:31:10 -0400
Received: by mail-ea0-f181.google.com with SMTP id d10so792636eaj.40
	for <qemu-devel@nongnu.org>; Wed, 07 Aug 2013 04:31:10 -0700 (PDT)
Date: Wed, 7 Aug 2013 13:31:07 +0200
From: Stefan Hajnoczi <stefanha@gmail.com>
Message-ID: <20130807113107.GA29076@stefanha-thinkpad.redhat.com>
References: <1375832956-7588-1-git-send-email-alex@alex.org.uk>
	<1375832956-7588-2-git-send-email-alex@alex.org.uk>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <1375832956-7588-2-git-send-email-alex@alex.org.uk>
Subject: Re: [Qemu-devel] [RFC] [PATCHv7 01/22] aio / timers: Add
 qemu_clock_free and expose qemu_clock_new and clock types
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Alex Bligh <alex@alex.org.uk>
Cc: Kevin Wolf <kwolf@redhat.com>, Anthony Liguori <aliguori@us.ibm.com>, qemu-devel@nongnu.org, liu ping fan <qemulist@gmail.com>, Stefan Hajnoczi <stefanha@redhat.com>, Paolo Bonzini <pbonzini@redhat.com>, MORITA Kazutaka <morita.kazutaka@lab.ntt.co.jp>, rth@twiddle.net

On Wed, Aug 07, 2013 at 12:48:55AM +0100, Alex Bligh wrote:
> Add qemu_clock_free and expose qemu_new_clock as qemu_clock_new.
> 
> Expose clock types.
> 
> Signed-off-by: Alex Bligh <alex@alex.org.uk>
> ---
>  include/qemu/timer.h |   22 ++++++++++++++++++++++
>  qemu-timer.c         |   11 ++++++-----
>  2 files changed, 28 insertions(+), 5 deletions(-)

Regarding doc comments: if the function is self-documenting then the doc
comment might not add much.  I think in those cases it's okay to omit
details about arguments or return values if they are clear from the
function prototype.

Reviewed-by: Stefan Hajnoczi <stefanha@redhat.com>