Re: [Qemu-devel] [PATCH v2 4/9] block: vhdx - log support struct and defines

[Kevin Wolf <kwolf@redhat.com>]

Am 01.08.2013 um 05:23 hat Jeff Cody geschrieben:
> This adds some magic number defines, and internal structure
> definitions for VHDX log replay support.
> 
> Signed-off-by: Jeff Cody <jcody@redhat.com>
> ---
>  block/vhdx.h | 21 ++++++++++++++++++++-
>  1 file changed, 20 insertions(+), 1 deletion(-)
> 
> diff --git a/block/vhdx.h b/block/vhdx.h
> index c8d8593..2db6615 100644
> --- a/block/vhdx.h
> +++ b/block/vhdx.h
> @@ -151,7 +151,10 @@ typedef struct QEMU_PACKED VHDXRegionTableEntry {
>  
>  
>  /* ---- LOG ENTRY STRUCTURES ---- */
> +#define VHDX_LOG_MIN_SIZE (1024*1024)

There should be spaces around the operator.

Also, VHDX_LOG_ENTRY_MIN_SIZE? I thought at first that this was the
minimum size of the whole log (or does that happen to be the same and I
just missed it in the spec?)

Kevin