From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:36152) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1V7BzL-00071L-20 for qemu-devel@nongnu.org; Wed, 07 Aug 2013 18:13:53 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1V7BzI-0008CD-Kl for qemu-devel@nongnu.org; Wed, 07 Aug 2013 18:13:50 -0400 Received: from wanbli.kerneis.info ([2001:41d0:8:38ad::1]:50637) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1V7BzI-0008Al-BT for qemu-devel@nongnu.org; Wed, 07 Aug 2013 18:13:48 -0400 Date: Wed, 7 Aug 2013 23:13:36 +0100 From: Gabriel Kerneis Message-ID: <20130807221336.GA4393@kerneis.info> References: <1375728247-1306-1-git-send-email-charlie@ctshepherd.com> <1375728247-1306-3-git-send-email-charlie@ctshepherd.com> <20130807191805.GA16226@stefanha-thinkpad.hitronhub.home> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20130807191805.GA16226@stefanha-thinkpad.hitronhub.home> Subject: Re: [Qemu-devel] [PATCH 2/5] qemu_coroutine_self should not be marked coroutine_fn as it cannot yield List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Stefan Hajnoczi Cc: kwolf@redhat.com, Charlie Shepherd , Charlie Shepherd , qemu-devel@nongnu.org, pbonzini@redhat.com On Wed, Aug 07, 2013 at 09:18:05PM +0200, Stefan Hajnoczi wrote: > I guess the practical problem is that CPC will get > upset that it's being called by the coroutine implementation from > non-coroutine contexts. But is it really the case? If Charlie added an annotation, it probably means that in practice it was only called from coroutine context anyway. The only downside from CPC's point of view is that there is a cost to making a coroutine_fn, and it's a pity to pay it when it's useless (ie. when the function never yields anyway). -- Gabriel