From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:49043)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <benoit.canet@irqsave.net>) id 1V7QNg-0004R5-65
	for qemu-devel@nongnu.org; Thu, 08 Aug 2013 09:36:02 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <benoit.canet@irqsave.net>) id 1V7QNZ-0005Dn-FH
	for qemu-devel@nongnu.org; Thu, 08 Aug 2013 09:35:55 -0400
Received: from nodalink.pck.nerim.net ([62.212.105.220]:54824
	helo=paradis.irqsave.net) by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <benoit.canet@irqsave.net>) id 1V7QNZ-0005DX-0r
	for qemu-devel@nongnu.org; Thu, 08 Aug 2013 09:35:49 -0400
Date: Thu, 8 Aug 2013 15:37:38 +0200
From: =?iso-8859-1?Q?Beno=EEt?= Canet <benoit.canet@irqsave.net>
Message-ID: <20130808133738.GA5217@irqsave.net>
References: <1374596968-20181-1-git-send-email-benoit@irqsave.net>
	<1374596968-20181-4-git-send-email-benoit@irqsave.net>
	<51F2CCD6.2020107@redhat.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=iso-8859-1
Content-Disposition: inline
In-Reply-To: <51F2CCD6.2020107@redhat.com>
Content-Transfer-Encoding: quoted-printable
Subject: Re: [Qemu-devel] [PATCH V3 for-1.6 3/5] block: Add support for
 throttling burst threshold in QMP and the command line.
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Eric Blake <eblake@redhat.com>
Cc: kwolf@redhat.com, qemu-devel@nongnu.org, stefanha@redhat.com

> Kevin's series renamed these to have a dash in the name, and also moved
> all the throttling parameters into a sub-struct.  Does it make more
> sense to have just '*throttling' with that sub-struct containing 12
> parameters, 6 for limits and 6 for thresholds, or would it be better to
> have '*throttling' with 6 members for limits, as well as
> '*throttling-threshold' with the other 6 members?  Naming-wise,
> throttling.bps-total and throttling-threshold.bps-total convey as much
> information as throttling.bps-total and throttling.bps-total-threshold.

Eric & Kevin:

Should compatible old style values be added for the new throttling option=
s in
order to avoid a mixed style mess in qemu-options.hx ?

Best regards

Beno=EEt