From: "Benoît Canet" <benoit.canet@irqsave.net>
To: Paolo Bonzini <pbonzini@redhat.com>
Cc: kwolf@redhat.com, qemu-devel@nongnu.org, stefanha@redhat.com
Subject: Re: [Qemu-devel] [PATCH V4 3/5] block: Enable the new throttling code in the block layer.o
Date: Thu, 8 Aug 2013 17:43:34 +0200 [thread overview]
Message-ID: <20130808154334.GA23734@irqsave.net> (raw)
In-Reply-To: <5203B991.90405@redhat.com>
> This is not really accurate; the cfq scheduler reorders reads and writes
> to have longer bursts, and these sometimes exceed the rate you set. I
> understood this is mostly for separate rd/wr settings, or did you
> reproduce it with "total" rates too?
I'll drop the comment.
It's only with read/write settings and not with total.
>
> Also, it would be better to have a workaround for this. Perhaps we
> could simply make the default value of max nonzero? In the old
> throttling code the slice time is 0.1s, so perhaps we could see what
> happens with max=0.1*avg.
I already set max to 0.1*avg if needed in the code.
next prev parent reply other threads:[~2013-08-08 15:41 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-08-08 14:29 [Qemu-devel] [PATCH V4 0/5] Continuous Leaky Bucket Throttling Benoît Canet
2013-08-08 14:29 ` [Qemu-devel] [PATCH V4 1/5] throttle: Add a new throttling API implementing continuous leaky bucket Benoît Canet
2013-08-08 14:29 ` [Qemu-devel] [PATCH V4 2/5] throttle: Add units tests Benoît Canet
2013-08-08 14:29 ` [Qemu-devel] [PATCH V4 3/5] block: Enable the new throttling code in the block layer Benoît Canet
2013-08-08 15:30 ` Paolo Bonzini
2013-08-08 15:43 ` Benoît Canet [this message]
2013-08-08 15:56 ` Benoît Canet
2013-08-08 14:29 ` [Qemu-devel] [PATCH V4 4/5] block: Add support for throttling burst max in QMP and the command line Benoît Canet
2013-08-08 14:29 ` [Qemu-devel] [PATCH V4 5/5] block: Add iops_sector_count to do the iops accounting for a given io size Benoît Canet
2013-08-09 12:05 ` [Qemu-devel] [PATCH V4 0/5] Continuous Leaky Bucket Throttling* Benoît Canet
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130808154334.GA23734@irqsave.net \
--to=benoit.canet@irqsave.net \
--cc=kwolf@redhat.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=stefanha@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).