From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:53338) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1V7SOx-0006gG-Lo for qemu-devel@nongnu.org; Thu, 08 Aug 2013 11:45:27 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1V7SOq-0005P4-9O for qemu-devel@nongnu.org; Thu, 08 Aug 2013 11:45:23 -0400 Received: from mx1.redhat.com ([209.132.183.28]:7397) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1V7SOq-0005Od-2d for qemu-devel@nongnu.org; Thu, 08 Aug 2013 11:45:16 -0400 Date: Thu, 8 Aug 2013 16:45:08 +0100 From: "Daniel P. Berrange" Message-ID: <20130808154507.GX14664@redhat.com> References: <1375938949-22622-1-git-send-email-rusty@rustcorp.com.au> <1375938949-22622-2-git-send-email-rusty@rustcorp.com.au> <87li4cgvh1.fsf@codemonkey.ws> <5203AB19.9070505@suse.de> <87r4e4p4wj.fsf@codemonkey.ws> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <87r4e4p4wj.fsf@codemonkey.ws> Content-Transfer-Encoding: quoted-printable Subject: Re: [Qemu-devel] [PATCH 1/7] virtio: allow byte swapping for vring and config access Reply-To: "Daniel P. Berrange" List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Anthony Liguori Cc: Peter Maydell , Rusty Russell , Andreas =?utf-8?Q?F=C3=A4rber?= , qemu-devel@nongnu.org On Thu, Aug 08, 2013 at 10:40:28AM -0500, Anthony Liguori wrote: > Andreas F=C3=A4rber writes: > >> We have a mechanism to do weak functions via stubs/. I think it wou= ld > >> be better to do cpu_get_byteswap() as a stub function and then overl= oad > >> it in the ppc64 code. > > > > If this as your name indicates is a per-CPU function then it should g= o > > into CPUClass. Interesting question is, what is virtio supposed to do= if > > we have two ppc CPUs, one is Big Endian, the other is Little Endian. >=20 > PPC64 is big endian. AFAIK, there is no such thing as a little endian > PPC64 processor. Unless I'm misunderstanding, this thread seems to suggest otherwise: "[Qemu-devel] [PATCH 0/5] 64bit PowerPC little endian support" https://lists.nongnu.org/archive/html/qemu-devel/2013-08/msg00813.html Daniel --=20 |: http://berrange.com -o- http://www.flickr.com/photos/dberrange= / :| |: http://libvirt.org -o- http://virt-manager.or= g :| |: http://autobuild.org -o- http://search.cpan.org/~danberr= / :| |: http://entangle-photo.org -o- http://live.gnome.org/gtk-vn= c :|