From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:37678) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1V7YoI-0005BD-7M for qemu-devel@nongnu.org; Thu, 08 Aug 2013 18:36:02 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1V7YoE-0002xJ-11 for qemu-devel@nongnu.org; Thu, 08 Aug 2013 18:35:58 -0400 Received: from mail-ie0-x232.google.com ([2607:f8b0:4001:c03::232]:39986) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1V7YoD-0002x8-Mx for qemu-devel@nongnu.org; Thu, 08 Aug 2013 18:35:53 -0400 Received: by mail-ie0-f178.google.com with SMTP id f4so2951461iea.37 for ; Thu, 08 Aug 2013 15:35:53 -0700 (PDT) Sender: fluxion Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable From: Michael Roth In-Reply-To: <20130807153925.16124.93648.stgit@hds.com> References: <20130807153925.16124.93648.stgit@hds.com> Message-ID: <20130808223548.20939.8488@loki> Date: Thu, 08 Aug 2013 17:35:48 -0500 Subject: Re: [Qemu-devel] [PATCH v10 00/10] qemu-ga: fsfreeze on Windows using VSS List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Tomoki Sekiyama , qemu-devel@nongnu.org Cc: libaiqing@huawei.com, ghammer@redhat.com, stefanha@gmail.com, lcapitulino@redhat.com, vrozenfe@redhat.com, pbonzini@redhat.com, seiji.aguchi@hds.com, lersek@redhat.com, areis@redhat.com Quoting Tomoki Sekiyama (2013-08-07 10:39:25) > Hi, > = > I rebased the patch series to add fsfreeze for Windows qemu-ga. > = > changes from v9: > - Fix conflict with commit e8ef31a3518c "qemu-ga: build it even if !sys= tem" > = > changes from v8: > - Add hEventTimeout to improve timeout error message (patch 07, see belo= w) > - Build qga-vss.tlb if configure'd --with-win-sdk (patch 05, 07) > - Use "qga-vss-dll-obj-$(CONFIG_QGA_VSS)" in Makefile.objs (patch 07) > - Fix typo in QGAVSSRequesterFunc (patch 07, 08) Everything looks good, went ahead and applied to qga branch and will send a PULL shortly after 1.7 development window opens up: https://github.com/mdroth/qemu/commits/qga Thanks for the series! > = > v9: http://lists.nongnu.org/archive/html/qemu-devel/2013-07/msg06071.html > = > * Description > In Windows, VSS (Volume Shadow Copy Service) provides a facility to > quiesce filesystems and applications before disk snapshots are taken. > This patch series implements "fsfreeze" command of qemu-ga using VSS. > = > = > * How to build & run qemu-ga with VSS support > = > - Download Microsoft VSS SDK from: > http://www.microsoft.com/en-us/download/details.aspx?id=3D23490 > = > - Setup the SDK > scripts/extract-vsssdk-headers setup.exe (on POSIX-systems) > = > - Specify installed SDK directory to configure option as: > ./configure --cross-prefix=3Di686-w64-mingw32- \ > --with-vss-sdk=3D"path/to/VSS SDK" \ > --without-systems --without-tools > = > - make qemu-ga.exe qga/vss-win32/qga-vss.{dll,tlb} > = > - Install qemu-ga.exe, qga/vss-win32/qga-vss.{dll,tlb}, and > the other required mingw libraries into the same directory in guests > = > - Run `qemu-ga.exe -s install' and `net start qemu-ga' in the guests > = > Any feedback are appreciated. > = > --- > Tomoki Sekiyama (10): > configure: Support configuring C++ compiler > Add c++ keywords to QAPI helper script > checkpatch.pl: Check .cpp files > Add a script to extract VSS SDK headers on POSIX system > qemu-ga: Add configure options to specify path to Windows/VSS SDK > error: Add error_set_win32 and error_setg_win32 > qemu-ga: Add Windows VSS provider and requester as DLL > qemu-ga: Call Windows VSS requester in fsfreeze command handler > qemu-ga: Install Windows VSS provider on `qemu-ga -s install' > QMP/qemu-ga-client: Make timeout longer for guest-fsfreeze-freeze c= ommand > = > = > .gitignore | 1 = > Makefile | 3 = > Makefile.objs | 2 = > QMP/qemu-ga-client | 4 = > configure | 96 +++++++ > hmp.c | 2 = > hw/pci/pci.c | 2 = > include/qapi/error.h | 13 + > qga/Makefile.objs | 3 = > qga/commands-win32.c | 82 ++++++ > qga/main.c | 10 + > qga/vss-win32.c | 166 +++++++++++++ > qga/vss-win32.h | 27 ++ > qga/vss-win32/Makefile.objs | 23 ++ > qga/vss-win32/install.cpp | 458 +++++++++++++++++++++++++++++++++++ > qga/vss-win32/provider.cpp | 523 ++++++++++++++++++++++++++++++++++= ++++++ > qga/vss-win32/qga-vss.def | 13 + > qga/vss-win32/qga-vss.idl | 20 ++ > qga/vss-win32/qga-vss.tlb | Bin > qga/vss-win32/requester.cpp | 507 ++++++++++++++++++++++++++++++++++= +++++ > qga/vss-win32/requester.h | 42 +++ > qga/vss-win32/vss-common.h | 129 ++++++++++ > rules.mak | 9 + > scripts/checkpatch.pl | 34 ++- > scripts/extract-vsssdk-headers | 35 +++ > scripts/qapi.py | 12 + > util/error.c | 35 +++ > 27 files changed, 2229 insertions(+), 22 deletions(-) > create mode 100644 qga/vss-win32.c > create mode 100644 qga/vss-win32.h > create mode 100644 qga/vss-win32/Makefile.objs > create mode 100644 qga/vss-win32/install.cpp > create mode 100644 qga/vss-win32/provider.cpp > create mode 100644 qga/vss-win32/qga-vss.def > create mode 100644 qga/vss-win32/qga-vss.idl > create mode 100644 qga/vss-win32/qga-vss.tlb > create mode 100644 qga/vss-win32/requester.cpp > create mode 100644 qga/vss-win32/requester.h > create mode 100644 qga/vss-win32/vss-common.h > create mode 100755 scripts/extract-vsssdk-headers