From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:39930)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <stefanha@gmail.com>) id 1V7ivD-0004tB-ED
	for qemu-devel@nongnu.org; Fri, 09 Aug 2013 05:23:56 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <stefanha@gmail.com>) id 1V7iv5-00087d-1h
	for qemu-devel@nongnu.org; Fri, 09 Aug 2013 05:23:47 -0400
Received: from mail-ee0-x236.google.com ([2a00:1450:4013:c00::236]:42733)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <stefanha@gmail.com>) id 1V7iv4-00087P-Ro
	for qemu-devel@nongnu.org; Fri, 09 Aug 2013 05:23:38 -0400
Received: by mail-ee0-f54.google.com with SMTP id e53so2005199eek.41
	for <qemu-devel@nongnu.org>; Fri, 09 Aug 2013 02:23:38 -0700 (PDT)
Date: Fri, 9 Aug 2013 11:23:35 +0200
From: Stefan Hajnoczi <stefanha@gmail.com>
Message-ID: <20130809092335.GE22210@stefanha-thinkpad.redhat.com>
References: <1375998147-24292-1-git-send-email-alex@alex.org.uk>
	<1375998147-24292-24-git-send-email-alex@alex.org.uk>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <1375998147-24292-24-git-send-email-alex@alex.org.uk>
Subject: Re: [Qemu-devel] [RFC] [PATCHv8 23/30] aio / timers: Rearrange
 timer.h & make legacy functions call non-legacy
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Alex Bligh <alex@alex.org.uk>
Cc: Kevin Wolf <kwolf@redhat.com>, Anthony Liguori <aliguori@us.ibm.com>, qemu-devel@nongnu.org, liu ping fan <qemulist@gmail.com>, Stefan Hajnoczi <stefanha@redhat.com>, Paolo Bonzini <pbonzini@redhat.com>, MORITA Kazutaka <morita.kazutaka@lab.ntt.co.jp>, rth@twiddle.net

On Thu, Aug 08, 2013 at 10:42:20PM +0100, Alex Bligh wrote:
> @@ -269,17 +299,17 @@ bool timerlist_expired(QEMUTimerList *timer_list);
>  int64_t timerlist_deadline_ns(QEMUTimerList *timer_list);
>  
>  /**
> - * timerlist_getclock:
> + * timerlist_get_clock:
>   * @timer_list: the timer list to operate on
>   *
>   * Read the clock value associated with a timer list.
>   * The clock value is normally in nanoseconds, but may
>   * not be in some instances (e.g. vm_clock with use_icount).

The documentation is wrong.  This function does not get the clock value
in nanoseconds.

> +/**
> + * timer_put:
> + * @f: the file
> + * @ts: the timer
> + */
> +void timer_put(QEMUFile *f, QEMUTimer *ts);

The struct is still called QEMUTimer, should that also be renamed?