qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: "Benoît Canet" <benoit.canet@irqsave.net>
To: qemu-devel@nongnu.org
Cc: kwolf@redhat.com, pbonzini@redhat.com, stefanha@redhat.com
Subject: Re: [Qemu-devel] [PATCH V4 0/5] Continuous Leaky Bucket Throttling*
Date: Fri, 9 Aug 2013 14:05:54 +0200	[thread overview]
Message-ID: <20130809120553.GA5161@irqsave.net> (raw)
In-Reply-To: <1375972194-3090-1-git-send-email-benoit@irqsave.net>

> It fail with the following error message at exit and I don't know why yet.
> qemu-system-x86_64: block.c:1489: bdrv_drain_all: Assertion
> `((&bs->tracked_requests)->lh_first == ((void *)0))' failed.

I solved this issue: bdrv_drain_all was bogus.

Best regards

Benoît

> 
>  block.c                   |  351 ++++++++++----------------------
>  block/qapi.c              |   50 +++--
>  blockdev.c                |  207 ++++++++++++++-----
>  hmp.c                     |   36 +++-
>  include/block/block.h     |    1 -
>  include/block/block_int.h |   32 +--
>  include/qemu/throttle.h   |  105 ++++++++++
>  qapi-schema.json          |   40 +++-
>  qemu-options.hx           |    4 +-
>  qmp-commands.hx           |   34 +++-
>  tests/Makefile            |    2 +
>  tests/test-throttle.c     |  494 +++++++++++++++++++++++++++++++++++++++++++++
>  util/Makefile.objs        |    1 +
>  util/throttle.c           |  391 +++++++++++++++++++++++++++++++++++
>  14 files changed, 1405 insertions(+), 343 deletions(-)
>  create mode 100644 include/qemu/throttle.h
>  create mode 100644 tests/test-throttle.c
>  create mode 100644 util/throttle.c
> 
> -- 
> 1.7.10.4
> 

      parent reply	other threads:[~2013-08-09 12:04 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-08-08 14:29 [Qemu-devel] [PATCH V4 0/5] Continuous Leaky Bucket Throttling Benoît Canet
2013-08-08 14:29 ` [Qemu-devel] [PATCH V4 1/5] throttle: Add a new throttling API implementing continuous leaky bucket Benoît Canet
2013-08-08 14:29 ` [Qemu-devel] [PATCH V4 2/5] throttle: Add units tests Benoît Canet
2013-08-08 14:29 ` [Qemu-devel] [PATCH V4 3/5] block: Enable the new throttling code in the block layer Benoît Canet
2013-08-08 15:30   ` Paolo Bonzini
2013-08-08 15:43     ` [Qemu-devel] [PATCH V4 3/5] block: Enable the new throttling code in the block layer.o Benoît Canet
2013-08-08 15:56     ` [Qemu-devel] [PATCH V4 3/5] block: Enable the new throttling code in the block layer Benoît Canet
2013-08-08 14:29 ` [Qemu-devel] [PATCH V4 4/5] block: Add support for throttling burst max in QMP and the command line Benoît Canet
2013-08-08 14:29 ` [Qemu-devel] [PATCH V4 5/5] block: Add iops_sector_count to do the iops accounting for a given io size Benoît Canet
2013-08-09 12:05 ` Benoît Canet [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20130809120553.GA5161@irqsave.net \
    --to=benoit.canet@irqsave.net \
    --cc=kwolf@redhat.com \
    --cc=pbonzini@redhat.com \
    --cc=qemu-devel@nongnu.org \
    --cc=stefanha@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).