From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:44407)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <benoit.canet@irqsave.net>) id 1V7lQR-0000KF-K8
	for qemu-devel@nongnu.org; Fri, 09 Aug 2013 08:04:18 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <benoit.canet@irqsave.net>) id 1V7lQL-0008RN-8C
	for qemu-devel@nongnu.org; Fri, 09 Aug 2013 08:04:11 -0400
Received: from nodalink.pck.nerim.net ([62.212.105.220]:55331
	helo=paradis.irqsave.net) by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <benoit.canet@irqsave.net>) id 1V7lQK-0008NH-T7
	for qemu-devel@nongnu.org; Fri, 09 Aug 2013 08:04:05 -0400
Date: Fri, 9 Aug 2013 14:05:54 +0200
From: =?iso-8859-1?Q?Beno=EEt?= Canet <benoit.canet@irqsave.net>
Message-ID: <20130809120553.GA5161@irqsave.net>
References: <1375972194-3090-1-git-send-email-benoit@irqsave.net>
MIME-Version: 1.0
Content-Type: text/plain; charset=iso-8859-1
Content-Disposition: inline
In-Reply-To: <1375972194-3090-1-git-send-email-benoit@irqsave.net>
Content-Transfer-Encoding: quoted-printable
Subject: Re: [Qemu-devel] [PATCH V4 0/5] Continuous Leaky Bucket Throttling*
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: qemu-devel@nongnu.org
Cc: kwolf@redhat.com, pbonzini@redhat.com, stefanha@redhat.com

> It fail with the following error message at exit and I don't know why y=
et.
> qemu-system-x86_64: block.c:1489: bdrv_drain_all: Assertion
> `((&bs->tracked_requests)->lh_first =3D=3D ((void *)0))' failed.

I solved this issue: bdrv_drain_all was bogus.

Best regards

Beno=EEt

>=20
>  block.c                   |  351 ++++++++++----------------------
>  block/qapi.c              |   50 +++--
>  blockdev.c                |  207 ++++++++++++++-----
>  hmp.c                     |   36 +++-
>  include/block/block.h     |    1 -
>  include/block/block_int.h |   32 +--
>  include/qemu/throttle.h   |  105 ++++++++++
>  qapi-schema.json          |   40 +++-
>  qemu-options.hx           |    4 +-
>  qmp-commands.hx           |   34 +++-
>  tests/Makefile            |    2 +
>  tests/test-throttle.c     |  494 +++++++++++++++++++++++++++++++++++++=
++++++++
>  util/Makefile.objs        |    1 +
>  util/throttle.c           |  391 +++++++++++++++++++++++++++++++++++
>  14 files changed, 1405 insertions(+), 343 deletions(-)
>  create mode 100644 include/qemu/throttle.h
>  create mode 100644 tests/test-throttle.c
>  create mode 100644 util/throttle.c
>=20
> --=20
> 1.7.10.4
>=20