From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:57908)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <kevin@koconnor.net>) id 1V7zZm-0005OO-Sj
	for qemu-devel@nongnu.org; Fri, 09 Aug 2013 23:10:54 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <kevin@koconnor.net>) id 1V7zZf-0005dI-I9
	for qemu-devel@nongnu.org; Fri, 09 Aug 2013 23:10:46 -0400
Received: from mail-vb0-f42.google.com ([209.85.212.42]:44639)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <kevin@koconnor.net>) id 1V7zZf-0005ca-C2
	for qemu-devel@nongnu.org; Fri, 09 Aug 2013 23:10:39 -0400
Received: by mail-vb0-f42.google.com with SMTP id e12so4562365vbg.1
	for <qemu-devel@nongnu.org>; Fri, 09 Aug 2013 20:10:39 -0700 (PDT)
Date: Fri, 9 Aug 2013 23:10:37 -0400
From: Kevin O'Connor <kevin@koconnor.net>
Message-ID: <20130810031037.GA8766@morn.localdomain>
References: <20130807145312.GA14308@redhat.com> <52034F73.4040904@redhat.com>
	<20130808083732.GB26837@redhat.com> <52035D88.6040002@redhat.com>
	<20130808095226.GB27298@redhat.com> <5203712C.8090202@redhat.com>
	<20130808141347.GA30200@redhat.com> <5203B1B7.5000102@redhat.com>
	<20130809041306.GB6869@morn.localdomain>
	<52048B3C.2030401@redhat.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <52048B3C.2030401@redhat.com>
Subject: Re: [Qemu-devel] [SeaBIOS] [PATCH] acpi: hide 64-bit PCI hole for
	Windows XP
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Gerd Hoffmann <kraxel@redhat.com>
Cc: Paolo Bonzini <pbonzini@redhat.com>, seabios@seabios.org, qemu-devel@nongnu.org, "Michael S. Tsirkin" <mst@redhat.com>

On Fri, Aug 09, 2013 at 08:25:00AM +0200, Gerd Hoffmann wrote:
> > I don't think SeaBIOS should continue to do the above once the tables
> > are moved to QEMU.  QEMU has all the info SeaBIOS has, so it can
> > generate the tables correctly on its own.
> 
> The loader script provided by qemu has fixup instructions, which is
> needed to fixup pointers to other acpi tables.  The idea is to use that
> mechanism to also allow th firmware to fixup addresses like pmbase in
> the qemu-generated tables.

Yes, but why should QEMU tell SeaBIOS to modify the table for pmbase
when it can just modify the table itself?

-Kevin