From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:48776) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1V8XJM-0006gZ-Bm for qemu-devel@nongnu.org; Sun, 11 Aug 2013 11:12:09 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1V8XJH-0001GN-Ky for qemu-devel@nongnu.org; Sun, 11 Aug 2013 11:12:04 -0400 Received: from mx1.redhat.com ([209.132.183.28]:20313) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1V8XJH-0001GG-Bo for qemu-devel@nongnu.org; Sun, 11 Aug 2013 11:11:59 -0400 Date: Sun, 11 Aug 2013 18:12:25 +0300 From: "Michael S. Tsirkin" Message-ID: <20130811151225.GB17849@redhat.com> References: <1375362537.4891.28.camel@localhost.localdomain> <1375427079-16822-1-git-send-email-hutao@cn.fujitsu.com> <51FB6D73.9090902@redhat.com> <20130811103341.GA13848@redhat.com> <5207A36F.2050308@suse.de> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline In-Reply-To: <5207A36F.2050308@suse.de> Content-Transfer-Encoding: quoted-printable Subject: Re: [Qemu-devel] [PATCH for-1.6 1/2] don't create pvpanic device by default. List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Andreas =?iso-8859-1?Q?F=E4rber?= Cc: Paolo Bonzini , qemu-devel@nongnu.org, Hu Tao On Sun, Aug 11, 2013 at 04:45:03PM +0200, Andreas F=E4rber wrote: > Am 11.08.2013 12:33, schrieb Michael S. Tsirkin: > > On Fri, Aug 02, 2013 at 10:27:31AM +0200, Paolo Bonzini wrote: > >> On 08/02/2013 09:04 AM, Hu Tao wrote: > >>> The problem with pvpanic being an internal device is that VMs runni= ng > >>> operating systems without a driver for this device will have proble= ms > >>> when qemu will be upgraded (from qemu without this pvpanic). > >>> > >>> The outcome may be, for example: in Windows(let's say XP) the Devic= e > >>> manager will open a "new device" wizard and the device will appear = as > >>> an unrecognized device. On a cluster with hundreds of such VMs, If > >>> that cluster has a health monitoring service it may show all the VM= s > >>> in a "not healthy" state. > >>> > >>> Reported-by: Marcel Apfelbaum > >>> Signed-off-by: Hu Tao > >> > >> NACK, > >> > >> this is premature. It is fundamentally a firmware problem. > >> > >> We have time to apply an even smaller patch that doesn't set > >> has_pvpanic to true, and delay the whole feature to 1.7, if we do > >> not fix the firmware in the next two weeks. > >> > >> Paolo > >=20 > > I think this is not just a firmware problem. Adding device by defaul= t > > was too rush, assumption was risk of guest bugs was 0. > >=20 > > We are now seeing problems with bios guest code and with linux guest > > drivers as well. Yes they all can be fixed, but we simply shouldn't > > force this risk of broken guests on everyone. > >=20 > > libvirt is the main user and libvirt people > > indicated their preference to creating device with > > -device pvpanic rather than a built-in one that > > can't be removed. > >=20 > > So please reconsider, and here's an ack from me. > >=20 > > Acked-by: Michael S. Tsirkin >=20 > NACK for this v1: As pointed out on the KVM call, we still need to keep > the pvpanic device around by default for pc-*-1.5. Removing has_pvpanic > completely therefore seems wrong. We also mentioned an option to patch 1.5 stable to change it there, but I'm fine with not doing it. > Can you submit a v2 for rc3 tomorrow? >=20 > Andreas > --=20 > SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 N=FCrnberg, Germany > GF: Jeff Hawn, Jennifer Guild, Felix Imend=F6rffer; HRB 16746 AG N=FCrn= berg