From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:36558) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1V8oLd-0003bs-J9 for qemu-devel@nongnu.org; Mon, 12 Aug 2013 05:23:40 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1V8oLX-0003vS-JJ for qemu-devel@nongnu.org; Mon, 12 Aug 2013 05:23:33 -0400 Received: from mx1.redhat.com ([209.132.183.28]:22400) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1V8oLX-0003vB-Bi for qemu-devel@nongnu.org; Mon, 12 Aug 2013 05:23:27 -0400 Date: Mon, 12 Aug 2013 12:25:00 +0300 From: "Michael S. Tsirkin" Message-ID: <20130812092500.GA30732@redhat.com> References: <1376295742-28528-1-git-send-email-mst@redhat.com> <1376295742-28528-2-git-send-email-mst@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Subject: Re: [Qemu-devel] [PATCH for-1.6 1/2] memory: export target page size List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Peter Maydell Cc: pbonzini@redhat.com, Anthony Liguori , Laszlo Ersek , qemu-devel@nongnu.org, Gerd Hoffmann On Mon, Aug 12, 2013 at 10:17:46AM +0100, Peter Maydell wrote: > On 12 August 2013 09:49, Michael S. Tsirkin wrote: > > Add symbol to make it possible to use target page size > > in target-independent code. > > Given that TARGET_PAGE_SIZE is "smallest page size the > TCG implementation currently supports for this core" > (ie it is a TCG internal implementation detail as much > as a property of the target CPU and it may well not > match the actual page size being used by the guest) > I would be very suspicious of any target-independent > code that uses it. > > -- PMM Look at the next patch and the comment justifying its use please. Point is migration works in units of TARGET_PAGE_SIZE and expects all RAM blocks to be a multiple of that. What if we rename this to qemu_migration_page_size ? Will this address your comment? -- MST