From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:35102)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <stefanha@gmail.com>) id 1V8qIU-0000uK-Dw
	for qemu-devel@nongnu.org; Mon, 12 Aug 2013 07:28:34 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <stefanha@gmail.com>) id 1V8qIL-0003zz-S3
	for qemu-devel@nongnu.org; Mon, 12 Aug 2013 07:28:26 -0400
Received: from mail-ee0-x22b.google.com ([2a00:1450:4013:c00::22b]:54451)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <stefanha@gmail.com>) id 1V8qIL-0003zl-M3
	for qemu-devel@nongnu.org; Mon, 12 Aug 2013 07:28:17 -0400
Received: by mail-ee0-f43.google.com with SMTP id e52so3462431eek.30
	for <qemu-devel@nongnu.org>; Mon, 12 Aug 2013 04:28:17 -0700 (PDT)
Date: Mon, 12 Aug 2013 13:28:14 +0200
From: Stefan Hajnoczi <stefanha@gmail.com>
Message-ID: <20130812112814.GA20725@stefanha-thinkpad.redhat.com>
References: <1376237638-6968-1-git-send-email-pbonzini@redhat.com>
	<1376237638-6968-2-git-send-email-pbonzini@redhat.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <1376237638-6968-2-git-send-email-pbonzini@redhat.com>
Subject: Re: [Qemu-devel] [PATCH 1/2] vmdk: support vmfsSparse files
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Paolo Bonzini <pbonzini@redhat.com>
Cc: kwolf@redhat.com, famz@redhat.com, qemu-devel@nongnu.org

On Sun, Aug 11, 2013 at 06:13:57PM +0200, Paolo Bonzini wrote:
> @@ -505,6 +505,34 @@ static int vmdk_open_vmdk3(BlockDriverState *bs,
>      return ret;
>  }
>  
> +static int vmdk_open_vmfs_sparse(BlockDriverState *bs,
> +                                 BlockDriverState *file,
> +                                 int flags)
> +{
> +    int ret;
> +    uint32_t magic;
> +    VMDK3Header header;
> +    VmdkExtent *extent;
> +
> +    ret = bdrv_pread(file, sizeof(magic), &header, sizeof(header));
> +    if (ret < 0) {
> +        return ret;
> +    }

magic is unused.  Did you forget to check it?