From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:50165)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <mst@redhat.com>) id 1V8tUg-0004UI-G0
	for qemu-devel@nongnu.org; Mon, 12 Aug 2013 10:53:21 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <mst@redhat.com>) id 1V8tUT-0008Rj-Q9
	for qemu-devel@nongnu.org; Mon, 12 Aug 2013 10:53:14 -0400
Received: from mx1.redhat.com ([209.132.183.28]:39861)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <mst@redhat.com>) id 1V8tUT-0008RQ-IY
	for qemu-devel@nongnu.org; Mon, 12 Aug 2013 10:53:01 -0400
Date: Mon, 12 Aug 2013 17:54:36 +0300
From: "Michael S. Tsirkin" <mst@redhat.com>
Message-ID: <20130812145436.GA31779@redhat.com>
References: <1376316104-11269-1-git-send-email-aliguori@us.ibm.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <1376316104-11269-1-git-send-email-aliguori@us.ibm.com>
Subject: Re: [Qemu-devel] [PATCH v2] pc: drop external DSDT loading
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Anthony Liguori <aliguori@us.ibm.com>
Cc: qemu-devel@nongnu.org, Gerd Hoffmann <kraxel@redhat.com>

On Mon, Aug 12, 2013 at 09:01:44AM -0500, Anthony Liguori wrote:
> This breaks migration and is unneeded with modern SeaBIOS.
> 
> Signed-off-by: Anthony Liguori <aliguori@us.ibm.com>

Hmm don't we want to keep it around for machine types
1.4.0 and 1.5.0?

By the way, copy stable as well?
Loading it unconditonally is a cross
version migration bug that we probably want to fix
on stable branch - disabling for 1.3.0 and older.

> ---
> v1 -> v2
>  - Still load external DSDT for q35
> ---
>  hw/i386/pc_piix.c | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/hw/i386/pc_piix.c b/hw/i386/pc_piix.c
> index 95c45b8..311574a 100644
> --- a/hw/i386/pc_piix.c
> +++ b/hw/i386/pc_piix.c
> @@ -103,7 +103,6 @@ static void pc_init1(MemoryRegion *system_memory,
>                                OBJECT(icc_bridge), NULL);
>  
>      pc_cpus_init(cpu_model, icc_bridge);
> -    pc_acpi_init("acpi-dsdt.aml");
>  
>      if (kvm_enabled() && kvmclock_enabled) {
>          kvmclock_create();
> -- 
> 1.8.0