From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:40443)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <flukshun@gmail.com>) id 1V933Y-0000wb-K2
	for qemu-devel@nongnu.org; Mon, 12 Aug 2013 21:05:57 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <flukshun@gmail.com>) id 1V933T-0003Ei-9d
	for qemu-devel@nongnu.org; Mon, 12 Aug 2013 21:05:52 -0400
Sender: fluxion <flukshun@gmail.com>
Content-Type: text/plain; charset="utf-8"
MIME-Version: 1.0
Content-Transfer-Encoding: quoted-printable
From: Michael Roth <mdroth@linux.vnet.ibm.com>
In-Reply-To: <51F2055B.9060400@weilnetz.de>
References: <20130726020346.25247.74538.malonedeb@gac.canonical.com>
	<20130726020346.25247.74538.malonedeb@gac.canonical.com>
	<51F2055B.9060400@weilnetz.de>
Message-ID: <20130813010532.26907.17548@loki>
Date: Mon, 12 Aug 2013 20:05:32 -0500
Subject: Re: [Qemu-devel] [Bug 1205156] [NEW] Errors while compiling version
	1.5.2
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Stefan Weil <sw@weilnetz.de>, Bug 1205156 <1205156@bugs.launchpad.net>
Cc: jean-christophe manciot <manciot.jeanchristophe@gmail.com>, qemu-stable@nongnu.org, qemu-devel@nongnu.org

Quoting Stefan Weil (2013-07-26 00:12:59)
> Am 26.07.2013 04:03, schrieb jean-christophe manciot:
> > Public bug reported:
> >
> > Environment: Ubuntu 13.04
> >
> > "hw/ide/macio.c: In function =E2=80=98pmac_ide_atapi_transfer_cb=E2=80=
=99:
> > hw/ide/macio.c:134:9: error: format =E2=80=98%lx=E2=80=99 expects argum=
ent of type =E2=80=98long unsigned int=E2=80=99, but argument 3 has type =
=E2=80=98hwaddr=E2=80=99 [-Werror=3Dformat]
> > hw/ide/macio.c: In function =E2=80=98pmac_ide_transfer_cb=E2=80=99:
> > hw/ide/macio.c:215:5: error: format =E2=80=98%ld=E2=80=99 expects argum=
ent of type =E2=80=98long int=E2=80=99, but argument 5 has type =E2=80=98in=
t64_t=E2=80=99 [-Werror=3Dformat]
> > hw/ide/macio.c:222:9: error: format =E2=80=98%lx=E2=80=99 expects argum=
ent of type =E2=80=98long unsigned int=E2=80=99, but argument 3 has type =
=E2=80=98hwaddr=E2=80=99 [-Werror=3Dformat]
> > hw/ide/macio.c:264:9: error: format =E2=80=98%lx=E2=80=99 expects argum=
ent of type =E2=80=98long unsigned int=E2=80=99, but argument 3 has type =
=E2=80=98hwaddr=E2=80=99 [-Werror=3Dformat]
> > cc1: all warnings being treated as errors
> > make: *** [hw/ide/macio.o] Error 1"
> >
> > I got the source files with a "git clone git://git.qemu-
> > project.org/qemu.git" + a recent "git fetch"
> >
> > ** Affects: qemu
> >      Importance: Undecided
> >          Status: New
> >
> =

> =

> =

> This patch should fix it: http://patchwork.ozlabs.org/patch/258774/.
> =

> It's also still missing in git master, but was already applied to
> qemu-trivial.

This doesn't seem to be vanilla 1.5.2, where 04dd1259 isn't applicable
(no MACIO_DPRINTF statements), but rather a newer release or past
version with this patch on top:

  commit 80fc95d8bdaf3392106b131a97ca701fd374489a
  Author: Alexander Graf <agraf@suse.de>
  Date:   Fri Jun 28 13:30:01 2013 +0200
  =

      PPC: dbdma: Support unaligned DMA access

I'd pull them both in if Alex wants to send a backported version for
1.5.2, but otherwise this doesn't seem to be an issue with stable.

> =

> Stefan