From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:46894)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <stefanha@redhat.com>) id 1V9Btb-0001Mc-3q
	for qemu-devel@nongnu.org; Tue, 13 Aug 2013 06:32:16 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <stefanha@redhat.com>) id 1V9BtW-0004pT-Hv
	for qemu-devel@nongnu.org; Tue, 13 Aug 2013 06:32:11 -0400
Received: from mx1.redhat.com ([209.132.183.28]:32100)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <stefanha@redhat.com>) id 1V9BtW-0004pF-AT
	for qemu-devel@nongnu.org; Tue, 13 Aug 2013 06:32:06 -0400
Date: Tue, 13 Aug 2013 12:31:57 +0200
From: Stefan Hajnoczi <stefanha@redhat.com>
Message-ID: <20130813103157.GA28051@stefanha-thinkpad.redhat.com>
References: <1376300525-14950-1-git-send-email-alex@alex.org.uk>
	<A89C810BE32059F910C78FD6@Ximines.local>
	<20130812095851.GC3983@dhcp-200-207.str.redhat.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20130812095851.GC3983@dhcp-200-207.str.redhat.com>
Subject: Re: [Qemu-devel] [PATCHv3] add qemu-img convert -C option (skip
 target volume creation)
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Kevin Wolf <kwolf@redhat.com>
Cc: Fam Zheng <famz@redhat.com>, Alexandre Derumier <aderumier@odiso.com>, Alex Bligh <alex@alex.org.uk>, qemu-devel@nongnu.org

On Mon, Aug 12, 2013 at 11:58:51AM +0200, Kevin Wolf wrote:
> Am 12.08.2013 um 11:44 hat Alex Bligh geschrieben:
> > 
> > 
> > --On 12 August 2013 10:42:05 +0100 Alex Bligh <alex@alex.org.uk> wrote:
> > 
> > >Add a -C option to skip volume creation on qemu-img convert.
> > >This is useful for targets such as rbd / ceph, where the
> > >target volume may already exist; we cannot always rely on
> > >qemu-img convert to create the image, as dependent on the
> > >output format, there may be parameters which are not possible
> > >to specify through the qemu-img convert command line.
> > >
> > >Code:
> > >
> > >Author: Alexandre Derumier <aderumier@odiso.com>
> > >Signed-off-by: Alexandre Derumier <aderumier@odiso.com>
> > >Signed-off-by: Alex Bligh <alex@alex.org.uk>
> > >
> > >Documentaton:
> > 
> > Would you consider taking this for 1.6? It's really hard
> > to do rbd work without it, and it's pretty harmless.
> 
> Stefan's decision, but considering that the very last release candidate
> is planned for today, I doubt that he's willing to take it. At least I
> wouldn't. Feature freeze was long ago, and even for real bug fixes I
> would be careful at this point and take nothing that isn't critical.
> 
> And even if he did take it, I wouldn't be surprised if Anthony simply
> refused to pull.

It's too late.  At this stage I'm just looking out for critical bug
fixes.

Stefan