From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:59017)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <mst@redhat.com>) id 1V9GEH-0001yp-NP
	for qemu-devel@nongnu.org; Tue, 13 Aug 2013 11:09:55 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <mst@redhat.com>) id 1V9GEB-0002q4-Hp
	for qemu-devel@nongnu.org; Tue, 13 Aug 2013 11:09:49 -0400
Received: from mx1.redhat.com ([209.132.183.28]:51934)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <mst@redhat.com>) id 1V9GEB-0002ps-BD
	for qemu-devel@nongnu.org; Tue, 13 Aug 2013 11:09:43 -0400
Date: Tue, 13 Aug 2013 18:11:16 +0300
From: "Michael S. Tsirkin" <mst@redhat.com>
Message-ID: <20130813151115.GA2309@redhat.com>
References: <1376310634-20778-1-git-send-email-mst@redhat.com>
	<1376310634-20778-3-git-send-email-mst@redhat.com>
	<CAFEAcA9UntFLJ8GYKQScCCTN2BFARsT+7L8JGQSoQekpBwMjMA@mail.gmail.com>
	<20130812185612.GA1616@redhat.com> <520A46E4.2000208@redhat.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <520A46E4.2000208@redhat.com>
Subject: Re: [Qemu-devel] [PATCH v2 for-1.6 v2 2/2] loader: put FW CFG ROM
	files into RAM
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Paolo Bonzini <pbonzini@redhat.com>
Cc: Peter Maydell <peter.maydell@linaro.org>, Anthony Liguori <aliguori@us.ibm.com>, Laszlo Ersek <lersek@redhat.com>, qemu-devel@nongnu.org, Gerd Hoffmann <kraxel@redhat.com>

On Tue, Aug 13, 2013 at 04:47:00PM +0200, Paolo Bonzini wrote:
> Il 12/08/2013 20:56, Michael S. Tsirkin ha scritto:
> >> > Similarly, what you're trying to do here doesn't require
> >> > that the guest sees any specific host pointer, so you should
> >> > just use memory_region_init_ram().
> > I was concerned that we are wasting resources here.
> > In particular, huge page memory might get allocated
> > and there's no need for it as it's never mapped
> > into guest.
> 
> You are also right, but I think this issue should be fixed separately
> (e.g. only use huge pages for main RAM).
> 
> Paolo

OK.
I switched to memory_region_init_ram for v3.