From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:57465) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1V9HfF-0007FN-W7 for qemu-devel@nongnu.org; Tue, 13 Aug 2013 12:41:50 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1V9HfB-0005rk-Ig for qemu-devel@nongnu.org; Tue, 13 Aug 2013 12:41:45 -0400 Sender: fluxion Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable From: Michael Roth In-Reply-To: References: <20130726020346.25247.74538.malonedeb@gac.canonical.com> <20130726020346.25247.74538.malonedeb@gac.canonical.com> <51F2055B.9060400@weilnetz.de> <20130813010532.26907.17548@loki> <20130813010703.26907.4700@loki> Message-ID: <20130813164128.17633.46924@loki> Date: Tue, 13 Aug 2013 11:41:28 -0500 Subject: Re: [Qemu-devel] [Bug 1205156] [NEW] Errors while compiling version 1.5.2 List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Alexander Graf Cc: Stefan Weil , jean-christophe manciot , "qemu-stable@nongnu.org" , Bug 1205156 <1205156@bugs.launchpad.net>, "qemu-devel@nongnu.org" Quoting Alexander Graf (2013-08-12 23:06:19) > Am 13.08.2013 um 03:07 schrieb Michael Roth : > = > > Quoting Michael Roth (2013-08-12 20:05:32) > >> Quoting Stefan Weil (2013-07-26 00:12:59) > >>> Am 26.07.2013 04:03, schrieb jean-christophe manciot: > >>>> Public bug reported: > >>>> = > >>>> Environment: Ubuntu 13.04 > >>>> = > >>>> "hw/ide/macio.c: In function =E2=80=98pmac_ide_atapi_transfer_cb=E2= =80=99: > >>>> hw/ide/macio.c:134:9: error: format =E2=80=98%lx=E2=80=99 expects ar= gument of type =E2=80=98long unsigned int=E2=80=99, but argument 3 has type= =E2=80=98hwaddr=E2=80=99 [-Werror=3Dformat] > >>>> hw/ide/macio.c: In function =E2=80=98pmac_ide_transfer_cb=E2=80=99: > >>>> hw/ide/macio.c:215:5: error: format =E2=80=98%ld=E2=80=99 expects ar= gument of type =E2=80=98long int=E2=80=99, but argument 5 has type =E2=80= =98int64_t=E2=80=99 [-Werror=3Dformat] > >>>> hw/ide/macio.c:222:9: error: format =E2=80=98%lx=E2=80=99 expects ar= gument of type =E2=80=98long unsigned int=E2=80=99, but argument 3 has type= =E2=80=98hwaddr=E2=80=99 [-Werror=3Dformat] > >>>> hw/ide/macio.c:264:9: error: format =E2=80=98%lx=E2=80=99 expects ar= gument of type =E2=80=98long unsigned int=E2=80=99, but argument 3 has type= =E2=80=98hwaddr=E2=80=99 [-Werror=3Dformat] > >>>> cc1: all warnings being treated as errors > >>>> make: *** [hw/ide/macio.o] Error 1" > >>>> = > >>>> I got the source files with a "git clone git://git.qemu- > >>>> project.org/qemu.git" + a recent "git fetch" > >>>> = > >>>> ** Affects: qemu > >>>> Importance: Undecided > >>>> Status: New > >>> = > >>> = > >>> = > >>> This patch should fix it: http://patchwork.ozlabs.org/patch/258774/. > >>> = > >>> It's also still missing in git master, but was already applied to > >>> qemu-trivial. > >> = > >> This doesn't seem to be vanilla 1.5.2, where 04dd1259 isn't applicable > >> (no MACIO_DPRINTF statements), but rather a newer release or past > >> version with this patch on top: > >> = > >> commit 80fc95d8bdaf3392106b131a97ca701fd374489a > >> Author: Alexander Graf > >> Date: Fri Jun 28 13:30:01 2013 +0200 > >> = > >> PPC: dbdma: Support unaligned DMA access > >> = > >> I'd pull them both in if Alex wants to send a backported version for > >> 1.5.2, but otherwise this doesn't seem to be an issue with stable. > > = > > Forgot to cc Alex. > = > I'd rather not backport these to 1.5, as the patches only make sense as a= whole with an OpenBIOS update. Ok, makes sense, just thought I'd double-check. Got the impression from the= bug report that maybe some downstreams were carrying your patch on top of 1.5.2= for OSX support, but I'm not really sure what's going on here. > = > IIUC the compile error has been fixed for 1.6, correct? Yup, should be fixed upstream with 04dd1259 > = > = > Alex > = > > = > >> = > >>> = > >>> Stefan