From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:58011) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1V9bq3-0006AM-Mz for qemu-devel@nongnu.org; Wed, 14 Aug 2013 10:14:21 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1V9bpy-0002MT-CC for qemu-devel@nongnu.org; Wed, 14 Aug 2013 10:14:15 -0400 Received: from mail-ee0-x22d.google.com ([2a00:1450:4013:c00::22d]:54118) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1V9bpy-0002MD-7B for qemu-devel@nongnu.org; Wed, 14 Aug 2013 10:14:10 -0400 Received: by mail-ee0-f45.google.com with SMTP id c50so4886857eek.32 for ; Wed, 14 Aug 2013 07:14:09 -0700 (PDT) Date: Wed, 14 Aug 2013 16:14:06 +0200 From: Stefan Hajnoczi Message-ID: <20130814141406.GA28912@stefanha-thinkpad.redhat.com> References: <1376070245-22557-1-git-send-email-charlie@ctshepherd.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1376070245-22557-1-git-send-email-charlie@ctshepherd.com> Subject: Re: [Qemu-devel] [RFC v2 01/15] Add an explanation of when a function should be marked coroutine_fn List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Charlie Shepherd Cc: kwolf@redhat.com, pbonzini@redhat.com, gabriel@kerneis.info, qemu-devel@nongnu.org On Fri, Aug 09, 2013 at 07:43:51PM +0200, Charlie Shepherd wrote: > Coroutine functions that can yield directly or indirectly should be annotated > with a coroutine_fn annotation. Add an explanation to that effect in > include/block/coroutine.h. > > Signed-off-by: Charlie Shepherd > --- > include/block/coroutine.h | 8 ++++++++ > 1 file changed, 8 insertions(+) A "Patch 00/NN" email that serves as a cover letter to explain the background and motivation for a patch series usually helps reviews understand the purpose of your patches. git-format-patch --cover-letter does this and git-publish automatically adds a cover letter when there is more than one patch. No need to resend, but please write a cover letter in the future. It will encourage reviews. Stefan