* [Qemu-devel] [PATCH for-1.6] virtio-9p-device: Avoid freeing uninitialized memory
@ 2013-07-31 23:59 Andreas Färber
2013-08-14 16:29 ` Anthony Liguori
0 siblings, 1 reply; 2+ messages in thread
From: Andreas Färber @ 2013-07-31 23:59 UTC (permalink / raw)
To: qemu-devel; +Cc: Anthony Liguori, Andreas Färber, Aneesh Kumar K.V
In virtio_9p_device_init() there are 6x goto out that will lead to
v9fs_path_free() attempting to free unitialized path.data field.
Easiest way to trigger is: qemu-system-x86_64 -device virtio-9p-pci
Fix this by moving v9fs_path_init() before any goto out.
Signed-off-by: Andreas Färber <afaerber@suse.de>
---
hw/9pfs/virtio-9p-device.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/hw/9pfs/virtio-9p-device.c b/hw/9pfs/virtio-9p-device.c
index de6f0fe..f0ffbe8 100644
--- a/hw/9pfs/virtio-9p-device.c
+++ b/hw/9pfs/virtio-9p-device.c
@@ -61,6 +61,8 @@ static int virtio_9p_device_init(VirtIODevice *vdev)
s->vq = virtio_add_queue(vdev, MAX_REQ, handle_9p_output);
+ v9fs_path_init(&path);
+
fse = get_fsdev_fsentry(s->fsconf.fsdev_id);
if (!fse) {
@@ -111,7 +113,6 @@ static int virtio_9p_device_init(VirtIODevice *vdev)
* call back to do that. Since we are in the init path, we don't
* use co-routines here.
*/
- v9fs_path_init(&path);
if (s->ops->name_to_path(&s->ctx, NULL, "/", &path) < 0) {
fprintf(stderr,
"error in converting name to path %s", strerror(errno));
--
1.8.1.4
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [Qemu-devel] [PATCH for-1.6] virtio-9p-device: Avoid freeing uninitialized memory
2013-07-31 23:59 [Qemu-devel] [PATCH for-1.6] virtio-9p-device: Avoid freeing uninitialized memory Andreas Färber
@ 2013-08-14 16:29 ` Anthony Liguori
0 siblings, 0 replies; 2+ messages in thread
From: Anthony Liguori @ 2013-08-14 16:29 UTC (permalink / raw)
To: None, qemu-devel; +Cc: Anthony Liguori, Aneesh Kumar K.V
Applied. Thanks.
Regards,
Anthony Liguori
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2013-08-14 16:29 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-07-31 23:59 [Qemu-devel] [PATCH for-1.6] virtio-9p-device: Avoid freeing uninitialized memory Andreas Färber
2013-08-14 16:29 ` Anthony Liguori
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).