From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:51946) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VAFe1-0002OY-Ms for qemu-devel@nongnu.org; Fri, 16 Aug 2013 04:44:35 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1VAFdw-0006qN-5N for qemu-devel@nongnu.org; Fri, 16 Aug 2013 04:44:29 -0400 Received: from hall.aurel32.net ([2001:470:1f0b:4a8::1]:34185) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VAFVN-0003et-14 for qemu-devel@nongnu.org; Fri, 16 Aug 2013 04:35:33 -0400 Date: Fri, 16 Aug 2013 10:35:22 +0200 From: Aurelien Jarno Message-ID: <20130816083522.GA4727@ohm.aurel32.net> References: <1375726045-20797-1-git-send-email-rth@twiddle.net> <1375726045-20797-5-git-send-email-rth@twiddle.net> <20130815155440.GA29032@ohm.aurel32.net> <520D3DEB.4020903@twiddle.net> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-15 Content-Disposition: inline In-Reply-To: <520D3DEB.4020903@twiddle.net> Subject: Re: [Qemu-devel] [PATCH for-next 4/8] tcg: Add mmu helpers that take a return address argument List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Richard Henderson Cc: qemu-devel@nongnu.org On Thu, Aug 15, 2013 at 01:45:31PM -0700, Richard Henderson wrote: > On 08/15/2013 08:54 AM, Aurelien Jarno wrote: > > Why removing this st*_cmmu versions? There might be a good reason, but > > it should be indicated in the patch description. > > Though the prototypes existed, the bodies were never generated. We already > ifdef out the store functions in the template when invoked for reading for code. > Fine then. Could you mention that in the commit message? -- Aurelien Jarno GPG: 1024D/F1BCDB73 aurelien@aurel32.net http://www.aurel32.net