From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:41289)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <stefanha@gmail.com>) id 1VAIoq-0001lV-1w
	for qemu-devel@nongnu.org; Fri, 16 Aug 2013 08:08:01 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <stefanha@gmail.com>) id 1VAIoh-0005Ee-Ig
	for qemu-devel@nongnu.org; Fri, 16 Aug 2013 08:07:51 -0400
Received: from mail-we0-x22f.google.com ([2a00:1450:400c:c03::22f]:38126)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <stefanha@gmail.com>) id 1VAIoh-0005EM-Cn
	for qemu-devel@nongnu.org; Fri, 16 Aug 2013 08:07:43 -0400
Received: by mail-we0-f175.google.com with SMTP id q58so1572602wes.34
	for <qemu-devel@nongnu.org>; Fri, 16 Aug 2013 05:07:42 -0700 (PDT)
Date: Fri, 16 Aug 2013 14:07:40 +0200
From: Stefan Hajnoczi <stefanha@gmail.com>
Message-ID: <20130816120740.GC22193@stefanha-thinkpad.redhat.com>
References: <1376326396-7676-1-git-send-email-benoit@irqsave.net>
	<1376326396-7676-5-git-send-email-benoit@irqsave.net>
MIME-Version: 1.0
Content-Type: text/plain; charset=iso-8859-1
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <1376326396-7676-5-git-send-email-benoit@irqsave.net>
Subject: Re: [Qemu-devel] [PATCH V5 4/5] block: Add support for throttling
 burst max in QMP and the command line.
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: =?iso-8859-1?Q?Beno=EEt?= Canet <benoit@irqsave.net>
Cc: kwolf@redhat.com, pbonzini@redhat.com, qemu-devel@nongnu.org, stefanha@redhat.com

On Mon, Aug 12, 2013 at 06:53:15PM +0200, Benoît Canet wrote:
> The max parameter of the leaky bycket throttling algoritm can be used to

s/bycket/bucket/
s/algoritm/algorithm/

> @@ -1098,7 +1112,19 @@ void hmp_block_set_io_throttle(Monitor *mon, const QDict *qdict)
>                                qdict_get_int(qdict, "bps_wr"),
>                                qdict_get_int(qdict, "iops"),
>                                qdict_get_int(qdict, "iops_rd"),
> -                              qdict_get_int(qdict, "iops_wr"), &err);
> +                              qdict_get_int(qdict, "iops_wr"),
> +                              false, /* no burst max via QMP */

s/QMP/HMP/

> @@ -1758,6 +1770,12 @@ Each json-object contain the following:
>           - "iops": limit total I/O operations per second (json-int)
>           - "iops_rd": limit read operations per second (json-int)
>           - "iops_wr": limit write operations per second (json-int)
> +         - "bps_max":  total max in bytes(json-int)

Space before "(json-int)" and for the others new fields too.