From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:42489) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VAIvM-0004qz-OK for qemu-devel@nongnu.org; Fri, 16 Aug 2013 08:14:45 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1VAIvB-0007iD-Hf for qemu-devel@nongnu.org; Fri, 16 Aug 2013 08:14:36 -0400 Received: from mail-wg0-x22e.google.com ([2a00:1450:400c:c00::22e]:46811) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VAIvB-0007i7-C5 for qemu-devel@nongnu.org; Fri, 16 Aug 2013 08:14:25 -0400 Received: by mail-wg0-f46.google.com with SMTP id k13so1468022wgh.1 for ; Fri, 16 Aug 2013 05:14:24 -0700 (PDT) Date: Fri, 16 Aug 2013 14:14:22 +0200 From: Stefan Hajnoczi Message-ID: <20130816121422.GE22193@stefanha-thinkpad.redhat.com> References: <1376326396-7676-1-git-send-email-benoit@irqsave.net> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <1376326396-7676-1-git-send-email-benoit@irqsave.net> Subject: Re: [Qemu-devel] [PATCH V5 0/5] Continuous Leaky Bucket Throttling List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: =?iso-8859-1?Q?Beno=EEt?= Canet Cc: kwolf@redhat.com, pbonzini@redhat.com, qemu-devel@nongnu.org, stefanha@redhat.com On Mon, Aug 12, 2013 at 06:53:11PM +0200, Benoît Canet wrote: > This patchset implement continous leaky bucket throttling. > > It use two requests queue to enable to do silly unbalanced throttling like > block_set_io_throttle 0 0 0 0 6000 1 > > It use two timer to get the timer callbacks and the throttle.c code simple > > It add unit tests. > > The throttling core is pretty solid and the surrouding of the patchset needs > polish. (new options ...) Looks promising. I still need to try it out and get familiar with how bursting ("max") works but I've left comments on the patches for now. Stefan