* [Qemu-devel] [PATCH v2 for 1.6] w32: Add missing version.o to all executables (fix regression)
@ 2013-08-08 18:18 Stefan Weil
2013-08-14 16:27 ` Anthony Liguori
2013-08-15 22:19 ` Michael Roth
0 siblings, 2 replies; 6+ messages in thread
From: Stefan Weil @ 2013-08-08 18:18 UTC (permalink / raw)
To: qemu-devel; +Cc: Paolo Bonzini, Anthony Liguori, Stefan Weil
QEMU executables for w32, w64 had included meta information built from
version.rc. These rules were changed several times some months ago.
The latest version added version.o to the tools, but not to the system
emulations.
This patch adds the meta information to all system emulations again.
Signed-off-by: Stefan Weil <sw@weilnetz.de>
---
v2:
This is a minimal fix for QEMU 1.6 based on Paolo's suggestion.
It can be improved later.
Regards,
Stefan
Makefile | 7 ++-----
Makefile.objs | 5 +++++
2 files changed, 7 insertions(+), 5 deletions(-)
diff --git a/Makefile b/Makefile
index 29f1043..4d257f1 100644
--- a/Makefile
+++ b/Makefile
@@ -167,11 +167,8 @@ recurse-all: $(SUBDIR_RULES) $(ROMSUBDIR_RULES)
bt-host.o: QEMU_CFLAGS += $(BLUEZ_CFLAGS)
-version.o: $(SRC_PATH)/version.rc config-host.h | version.lo
-version.lo: $(SRC_PATH)/version.rc config-host.h
-
-version-obj-$(CONFIG_WIN32) += version.o
-version-lobj-$(CONFIG_WIN32) += version.lo
+$(BUILD_DIR)/version.o: $(SRC_PATH)/version.rc $(BUILD_DIR)/config-host.h | $(BUILD_DIR)/version.lo
+$(BUILD_DIR)/version.lo: $(SRC_PATH)/version.rc $(BUILD_DIR)/config-host.h
Makefile: $(version-obj-y) $(version-lobj-y)
diff --git a/Makefile.objs b/Makefile.objs
index 9928542..f46a4cd 100644
--- a/Makefile.objs
+++ b/Makefile.objs
@@ -99,6 +99,11 @@ common-obj-y += qom/
common-obj-y += disas/
######################################################################
+# Resource file for Windows executables
+version-obj-$(CONFIG_WIN32) += $(BUILD_DIR)/version.o
+version-lobj-$(CONFIG_WIN32) += $(BUILD_DIR)/version.lo
+
+######################################################################
# guest agent
# FIXME: a few definitions from qapi-types.o/qapi-visit.o are needed
--
1.7.10.4
^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [Qemu-devel] [PATCH v2 for 1.6] w32: Add missing version.o to all executables (fix regression)
2013-08-08 18:18 [Qemu-devel] [PATCH v2 for 1.6] w32: Add missing version.o to all executables (fix regression) Stefan Weil
@ 2013-08-14 16:27 ` Anthony Liguori
2013-08-15 22:19 ` Michael Roth
1 sibling, 0 replies; 6+ messages in thread
From: Anthony Liguori @ 2013-08-14 16:27 UTC (permalink / raw)
To: Stefan Weil, qemu-devel; +Cc: Paolo Bonzini, Anthony Liguori
Applied. Thanks.
Regards,
Anthony Liguori
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [Qemu-devel] [PATCH v2 for 1.6] w32: Add missing version.o to all executables (fix regression)
2013-08-08 18:18 [Qemu-devel] [PATCH v2 for 1.6] w32: Add missing version.o to all executables (fix regression) Stefan Weil
2013-08-14 16:27 ` Anthony Liguori
@ 2013-08-15 22:19 ` Michael Roth
2013-08-16 5:55 ` Stefan Weil
1 sibling, 1 reply; 6+ messages in thread
From: Michael Roth @ 2013-08-15 22:19 UTC (permalink / raw)
To: Stefan Weil, qemu-devel; +Cc: Paolo Bonzini, Anthony Liguori
Quoting Stefan Weil (2013-08-08 13:18:07)
> QEMU executables for w32, w64 had included meta information built from
> version.rc. These rules were changed several times some months ago.
>
> The latest version added version.o to the tools, but not to the system
> emulations.
>
> This patch adds the meta information to all system emulations again.
>
> Signed-off-by: Stefan Weil <sw@weilnetz.de>
I seem to be getting build errors with this patch when doing a Fedora 18 mingw
crossbuild. I thought it was specific to qemu-ga so I disabled it to confirm
and it looks like version.o is never being built, so all targets fail when
linking.
Reverting this patch seems to fix things
Output follows:
[mdroth@vm5 qemu-build2]$ rm -rf * && /home/mdroth/w/qemu2.git/configure --target-list=x86_64-softmmu --cross-prefix=i686-w64-mingw32- --disable-guest-agent && make -j4
Install prefix c:/Program Files/QEMU
BIOS directory c:/Program Files/QEMU
binary directory c:/Program Files/QEMU
library directory c:/Program Files/QEMU/lib
libexec directory c:/Program Files/QEMU/libexec
include directory c:/Program Files/QEMU/include
config directory c:/Program Files/QEMU
local state directory queried at runtime
Source path /home/mdroth/w/qemu2.git
C compiler i686-w64-mingw32-gcc
Host C compiler cc
Objective-C compiler i686-w64-mingw32-gcc
CFLAGS -O2 -D_FORTIFY_SOURCE=2 -g
QEMU_CFLAGS -m32 -D__USE_MINGW_ANSI_STDIO=1 -DWIN32_LEAN_AND_MEAN -DWINVER=0x501 -D_GNU_SOURCE -D_FILE_OFFSET_BITS=64 -D_LARGEFILE_SOURCE -Wstrict-prototypes -Wredundant-decls -Wall -Wundef -Wwrite-strings -Wmissing-prototypes -fno-strict-aliasing -Wendif-labels -Wmissing-include-dirs -Wempty-body -Wnested-externs -Wformat-security -Wformat-y2k -Winit-self -Wignored-qualifiers -Wold-style-declaration -Wold-style-definition -Wtype-limits -fstack-protector-all -I/usr/i686-w64-mingw32/sys-root/mingw/include -I/usr/i686-w64-mingw32/sys-root/mingw/include/p11-kit-1 -I/usr/i686-w64-mingw32/sys-root/mingw/include/pixman-1 -I$(SRC_PATH)/dtc/libfdt
LDFLAGS -Wl,--nxcompat -Wl,--no-seh -Wl,--dynamicbase -Wl,--warn-common -m32 -g
make make
install install
python python
smbd /usr/sbin/smbd
host CPU i386
host big endian no
target list x86_64-softmmu
tcg debug enabled no
gprof enabled no
sparse enabled no
strip binaries yes
profiler no
static build no
-Werror enabled no
pixman system
SDL support no
GTK support no
curses support no
curl support no
mingw32 support yes
Audio drivers winwave
Block whitelist (rw)
Block whitelist (ro)
Mixer emulation no
VirtFS support no
VNC support yes
VNC TLS support yes
VNC SASL support no
VNC JPEG support no
VNC PNG support no
VNC WS support yes
xen support no
brlapi support no
bluez support no
Documentation no
GUEST_BASE yes
PIE no
vde support no
Linux AIO support no
ATTR/XATTR support no
Install blobs yes
KVM support no
RDMA support no
TCG interpreter no
fdt support yes
preadv support no
fdatasync no
madvise no
posix_madvise no
sigev_thread_id no
uuid support no
libcap-ng support no
vhost-net support no
vhost-scsi support no
Trace backend nop
Trace output file trace-<pid>
spice support no (/)
rbd support no
xfsctl support no
nss used no
libusb no
usb net redir no
GLX support no
libiscsi support no
build guest agent no
seccomp support no
coroutine backend win32
GlusterFS support no
virtio-blk-data-plane no
gcov gcov
gcov enabled no
TPM support no
libssh2 support no
TPM passthrough no
QOM debugging yes
GEN x86_64-softmmu/config-devices.mak
mkdir -p dtc/libfdt
GEN config-/home/mdroth/qemu-build2/host.h
GEN config-host.h
mkdir -p dtc/tests
GEN qemu-options.def
GEN qmp-commands.h
GEN qapi-types.h
GEN qapi-visit.h
GEN trace/generated-events.h
GEN trace/generated-tracers.h
GEN tests/test-qapi-types.h
GEN tests/test-qapi-visit.h
GEN tests/test-qmp-commands.h
GEN config-all-devices.mak
DEP /home/mdroth/w/qemu2.git/dtc/tests/dumptrees.c
DEP /home/mdroth/w/qemu2.git/dtc/tests/trees.S
DEP /home/mdroth/w/qemu2.git/dtc/tests/testutils.c
DEP /home/mdroth/w/qemu2.git/dtc/tests/value-labels.c
DEP /home/mdroth/w/qemu2.git/dtc/tests/asm_tree_dump.c
DEP /home/mdroth/w/qemu2.git/dtc/tests/truncated_property.c
DEP /home/mdroth/w/qemu2.git/dtc/tests/path_offset_aliases.c
DEP /home/mdroth/w/qemu2.git/dtc/tests/add_subnode_with_nops.c
DEP /home/mdroth/w/qemu2.git/dtc/tests/dtb_reverse.c
DEP /home/mdroth/w/qemu2.git/dtc/tests/dtbs_equal_unordered.c
DEP /home/mdroth/w/qemu2.git/dtc/tests/dtbs_equal_ordered.c
DEP /home/mdroth/w/qemu2.git/dtc/tests/extra-terminating-null.c
DEP /home/mdroth/w/qemu2.git/dtc/tests/boot-cpuid.c
DEP /home/mdroth/w/qemu2.git/dtc/tests/incbin.c
DEP /home/mdroth/w/qemu2.git/dtc/tests/phandle_format.c
DEP /home/mdroth/w/qemu2.git/dtc/tests/path-references.c
DEP /home/mdroth/w/qemu2.git/dtc/tests/references.c
DEP /home/mdroth/w/qemu2.git/dtc/tests/string_escapes.c
DEP /home/mdroth/w/qemu2.git/dtc/tests/del_node.c
DEP /home/mdroth/w/qemu2.git/dtc/tests/del_property.c
DEP /home/mdroth/w/qemu2.git/dtc/tests/setprop.c
DEP /home/mdroth/w/qemu2.git/dtc/tests/set_name.c
DEP /home/mdroth/w/qemu2.git/dtc/tests/rw_tree1.c
DEP /home/mdroth/w/qemu2.git/dtc/tests/open_pack.c
DEP /home/mdroth/w/qemu2.git/dtc/tests/nopulate.c
DEP /home/mdroth/w/qemu2.git/dtc/tests/mangle-layout.c
DEP /home/mdroth/w/qemu2.git/dtc/tests/move_and_save.c
DEP /home/mdroth/w/qemu2.git/dtc/tests/sw_tree1.c
DEP /home/mdroth/w/qemu2.git/dtc/tests/nop_node.c
DEP /home/mdroth/w/qemu2.git/dtc/tests/nop_property.c
DEP /home/mdroth/w/qemu2.git/dtc/tests/setprop_inplace.c
DEP /home/mdroth/w/qemu2.git/dtc/tests/notfound.c
DEP /home/mdroth/w/qemu2.git/dtc/tests/get_alias.c
DEP /home/mdroth/w/qemu2.git/dtc/tests/node_offset_by_compatible.c
DEP /home/mdroth/w/qemu2.git/dtc/tests/node_check_compatible.c
DEP /home/mdroth/w/qemu2.git/dtc/tests/node_offset_by_phandle.c
DEP /home/mdroth/w/qemu2.git/dtc/tests/node_offset_by_prop_value.c
DEP /home/mdroth/w/qemu2.git/dtc/tests/parent_offset.c
DEP /home/mdroth/w/qemu2.git/dtc/tests/get_path.c
DEP /home/mdroth/w/qemu2.git/dtc/tests/get_phandle.c
DEP /home/mdroth/w/qemu2.git/dtc/tests/supernode_atdepth_offset.c
DEP /home/mdroth/w/qemu2.git/dtc/tests/getprop.c
DEP /home/mdroth/w/qemu2.git/dtc/tests/get_name.c
DEP /home/mdroth/w/qemu2.git/dtc/tests/path_offset.c
DEP /home/mdroth/w/qemu2.git/dtc/tests/subnode_offset.c
DEP /home/mdroth/w/qemu2.git/dtc/tests/find_property.c
DEP /home/mdroth/w/qemu2.git/dtc/tests/root_node.c
DEP /home/mdroth/w/qemu2.git/dtc/tests/get_mem_rsv.c
DEP /home/mdroth/w/qemu2.git/dtc/libfdt/fdt_strerror.c
DEP /home/mdroth/w/qemu2.git/dtc/libfdt/fdt_rw.c
DEP /home/mdroth/w/qemu2.git/dtc/libfdt/fdt_sw.c
DEP /home/mdroth/w/qemu2.git/dtc/libfdt/fdt_wip.c
DEP /home/mdroth/w/qemu2.git/dtc/libfdt/fdt_ro.c
DEP /home/mdroth/w/qemu2.git/dtc/libfdt/fdt.c
DEP /home/mdroth/w/qemu2.git/dtc/ftdump.c
LEX convert-dtsv0-lexer.lex.c
make[1]: flex: Command not found
DEP /home/mdroth/w/qemu2.git/dtc/util.c
DEP /home/mdroth/w/qemu2.git/dtc/srcpos.c
LEX dtc-lexer.lex.c
BISON dtc-parser.tab.c
make[1]: bison: Command not found
make[1]: flex: Command not found
DEP /home/mdroth/w/qemu2.git/dtc/treesource.c
DEP /home/mdroth/w/qemu2.git/dtc/livetree.c
DEP /home/mdroth/w/qemu2.git/dtc/fstree.c
DEP /home/mdroth/w/qemu2.git/dtc/flattree.c
DEP /home/mdroth/w/qemu2.git/dtc/dtc.c
DEP /home/mdroth/w/qemu2.git/dtc/data.c
DEP /home/mdroth/w/qemu2.git/dtc/checks.c
LEX convert-dtsv0-lexer.lex.c
BISON dtc-parser.tab.c
make[1]: flex: Command not found
make[1]: bison: Command not found
LEX dtc-lexer.lex.c
make[1]: flex: Command not found
CHK version_gen.h
UPD version_gen.h
DEP /home/mdroth/w/qemu2.git/dtc/dtc.c
LEX convert-dtsv0-lexer.lex.c
make[1]: flex: Command not found
BISON dtc-parser.tab.c
LEX dtc-lexer.lex.c
make[1]: bison: Command not found
make[1]: flex: Command not found
CC libfdt/fdt.o
CC libfdt/fdt_wip.o
CC libfdt/fdt_sw.o
CC libfdt/fdt_ro.o
CC libfdt/fdt_rw.o
CC libfdt/fdt_strerror.o
AR libfdt/libfdt.a
i686-w64-mingw32-ar: creating libfdt/libfdt.a
a - libfdt/fdt.o
a - libfdt/fdt_ro.o
a - libfdt/fdt_wip.o
a - libfdt/fdt_sw.o
a - libfdt/fdt_rw.o
a - libfdt/fdt_strerror.o
rm /home/mdroth/qemu-build2/config-host.h-timestamp
GEN config-host.h
LEX convert-dtsv0-lexer.lex.c
BISON dtc-parser.tab.c
make[1]: flex: Command not found
LEX dtc-lexer.lex.c
make[1]: bison: Command not found
make[1]: flex: Command not found
GEN qemu-img-cmds.h
CC async.o
CC thread-pool.o
CC block.o
CC nbd.o
CC blockjob.o
CC main-loop.o
CC iohandler.o
CC qemu-timer.o
CC aio-win32.o
GEN qapi-types.c
GEN qga/qapi-generated/qga-qapi-types.h
GEN qga/qapi-generated/qga-qapi-visit.h
GEN qga/qapi-generated/qga-qmp-commands.h
GEN qapi-visit.c
CC qemu-io-cmds.o
CC qemu-coroutine.o
CC qemu-coroutine-lock.o
CC qemu-coroutine-io.o
CC qemu-coroutine-sleep.o
CC coroutine-win32.o
CC block/raw.o
CC block/cow.o
CC block/qcow.o
CC block/vdi.o
CC block/vmdk.o
CC block/cloop.o
CC block/dmg.o
CC block/bochs.o
CC block/vpc.o
CC block/vvfat.o
CC block/qcow2.o
CC block/qcow2-refcount.o
CC block/qcow2-cluster.o
CC block/qcow2-snapshot.o
CC block/qcow2-cache.o
CC block/qed.o
CC block/qed-gencb.o
CC block/qed-l2-cache.o
CC block/qed-table.o
CC block/qed-cluster.o
CC block/qed-check.o
CC block/vhdx.o
CC block/parallels.o
CC block/blkdebug.o
CC block/blkverify.o
CC block/snapshot.o
CC block/qapi.o
CC block/raw-win32.o
CC block/win32-aio.o
CC qapi/qapi-visit-core.o
CC qapi/qapi-dealloc-visitor.o
CC qapi/qmp-input-visitor.o
CC qapi/qmp-output-visitor.o
CC qapi/qmp-registry.o
CC qapi/qmp-dispatch.o
CC qapi/string-input-visitor.o
CC qapi/string-output-visitor.o
CC qapi/opts-visitor.o
CC qobject/qint.o
CC qobject/qstring.o
CC qobject/qdict.o
CC qobject/qlist.o
CC qobject/qfloat.o
CC qobject/qbool.o
CC qobject/qjson.o
CC qobject/json-lexer.o
CC qobject/json-streamer.o
CC qobject/json-parser.o
CC qobject/qerror.o
GEN trace/generated-events.c
CC trace/default.o
CC trace/control.o
GEN trace/generated-tracers.c
CC util/osdep.o
CC util/cutils.o
CC util/unicode.o
CC util/qemu-timer-common.o
CC util/oslib-win32.o
CC util/qemu-thread-win32.o
CC util/event_notifier-win32.o
CC util/envlist.o
CC util/path.o
CC util/host-utils.o
CC util/cache-utils.o
CC util/module.o
CC util/bitmap.o
CC util/bitops.o
CC util/hbitmap.o
CC util/fifo8.o
CC util/acl.o
CC util/error.o
CC util/qemu-error.o
CC util/iov.o
CC util/aes.o
CC util/qemu-config.o
CC util/qemu-sockets.o
CC util/uri.o
CC util/notify.o
CC util/qemu-option.o
CC util/qemu-progress.o
CC util/hexdump.o
CC util/crc32c.o
CC stubs/arch-query-cpu-def.o
CC stubs/clock-warp.o
CC stubs/cpu-get-clock.o
CC stubs/cpu-get-icount.o
CC stubs/dump.o
CC stubs/fdset-add-fd.o
CC stubs/fdset-find-fd.o
CC stubs/fdset-get-fd.o
CC stubs/fdset-remove-fd.o
CC stubs/gdbstub.o
CC stubs/get-fd.o
CC stubs/get-vm-name.o
CC stubs/iothread-lock.o
CC stubs/migr-blocker.o
CC stubs/mon-is-qmp.o
CC stubs/mon-printf.o
CC stubs/mon-print-filename.o
CC stubs/mon-protocol-event.o
CC stubs/mon-set-error.o
CC stubs/pci-drive-hot-add.o
CC stubs/reset.o
CC stubs/set-fd-handler.o
CC stubs/slirp.o
CC stubs/sysbus.o
CC stubs/vm-stop.o
CC stubs/vmstate.o
CC stubs/fd-register.o
CC stubs/cpus.o
CC qemu-io.o
CC blockdev.o
CC blockdev-nbd.o
CC readline.o
CC qdev-monitor.o
CC device-hotplug.o
CC os-win32.o
CC migration.o
CC migration-tcp.o
CC qemu-char.o
CC block-migration.o
CC page_cache.o
CC xbzrle.o
CC bt-host.o
CC bt-vhci.o
CC dma-helpers.o
CC vl.o
CC tpm.o
GEN qmp-marshal.c
CC qmp.o
CC hmp.o
CC qemu-log.o
CC tcg-runtime.o
CC audio/audio.o
CC audio/noaudio.o
CC audio/wavaudio.o
CC audio/mixeng.o
CC audio/winwaveaudio.o
CC audio/audio_win_int.o
CC audio/wavcapture.o
CC backends/rng.o
CC backends/rng-egd.o
CC backends/msmouse.o
CC block/stream.o
CC block/commit.o
CC block/mirror.o
CC block/backup.o
CC disas/i386.o
CC net/net.o
CC net/queue.o
CC net/checksum.o
CC net/util.o
CC net/hub.o
CC net/socket.o
CC net/dump.o
CC net/eth.o
CC net/tap-win32.o
CC net/slirp.o
CC qom/object.o
CC qom/container.o
CC qom/qom-qobject.o
CC qom/cpu.o
CC slirp/cksum.o
CC slirp/if.o
CC slirp/ip_icmp.o
CC slirp/ip_input.o
CC slirp/ip_output.o
CC slirp/dnssearch.o
CC slirp/slirp.o
CC slirp/mbuf.o
CC slirp/misc.o
CC slirp/sbuf.o
CC slirp/socket.o
CC slirp/tcp_input.o
CC slirp/tcp_output.o
CC slirp/tcp_subr.o
CC slirp/tcp_timer.o
CC slirp/udp.o
CC slirp/bootp.o
CC slirp/tftp.o
CC slirp/arp_table.o
CC ui/keymaps.o
CC ui/console.o
CC ui/cursor.o
CC ui/input.o
CC ui/qemu-pixman.o
CC ui/vnc.o
CC ui/d3des.o
CC ui/vnc-enc-zlib.o
CC ui/vnc-enc-hextile.o
CC ui/vnc-enc-tight.o
CC ui/vnc-palette.o
CC ui/vnc-enc-zrle.o
CC ui/vnc-tls.o
CC ui/vnc-auth-vencrypt.o
CC ui/vnc-ws.o
CC ui/vnc-jobs.o
CC hw/acpi/core.o
CC hw/acpi/piix4.o
CC hw/acpi/ich9.o
CC hw/audio/sb16.o
CC hw/audio/es1370.o
CC hw/audio/ac97.o
CC hw/audio/fmopl.o
CC hw/audio/adlib.o
CC hw/audio/gus.o
CC hw/audio/gusemu_hal.o
CC hw/audio/gusemu_mixer.o
CC hw/audio/cs4231a.o
CC hw/audio/intel-hda.o
CC hw/audio/hda-codec.o
CC hw/audio/pcspk.o
CC hw/block/block.o
CC hw/block/cdrom.o
CC hw/block/hd-geometry.o
CC hw/block/fdc.o
CC hw/block/pflash_cfi01.o
CC hw/block/nvme.o
CC hw/bt/core.o
CC hw/bt/l2cap.o
CC hw/bt/sdp.o
CC hw/bt/hci.o
CC hw/bt/hid.o
CC hw/bt/hci-csr.o
CC hw/char/tpci200.o
CC hw/char/ipoctal232.o
CC hw/char/ipack.o
CC hw/char/parallel.o
CC hw/char/serial.o
CC hw/char/serial-isa.o
CC hw/char/serial-pci.o
CC hw/char/virtio-console.o
CC hw/char/debugcon.o
CC hw/core/qdev.o
CC hw/core/qdev-properties.o
CC hw/core/irq.o
CC hw/core/sysbus.o
CC hw/core/null-machine.o
CC hw/core/loader.o
CC hw/core/qdev-properties-system.o
CC hw/display/cirrus_vga.o
CC hw/display/vga-pci.o
CC hw/display/vga-isa.o
CC hw/display/vmware_vga.o
CC hw/dma/i8257.o
CC hw/i2c/core.o
CC hw/i2c/smbus.o
CC hw/i2c/smbus_eeprom.o
CC hw/i2c/smbus_ich9.o
CC hw/i2c/pm_smbus.o
CC hw/ide/core.o
CC hw/ide/atapi.o
CC hw/ide/qdev.o
CC hw/ide/pci.o
CC hw/ide/isa.o
CC hw/ide/piix.o
CC hw/ide/ahci.o
CC hw/ide/ich.o
CC hw/input/hid.o
CC hw/input/pckbd.o
CC hw/input/ps2.o
CC hw/input/vmmouse.o
CC hw/intc/i8259_common.o
CC hw/intc/i8259.o
CC hw/intc/ioapic_common.o
CC hw/isa/isa-bus.o
CC hw/isa/apm.o
CC hw/misc/applesmc.o
CC hw/misc/debugexit.o
CC hw/misc/sga.o
CC hw/misc/pc-testdev.o
CC hw/misc/pci-testdev.o
CC hw/net/ne2000.o
CC hw/net/eepro100.o
CC hw/net/pcnet-pci.o
CC hw/net/pcnet.o
CC hw/net/e1000.o
CC hw/net/rtl8139.o
CC hw/net/vmxnet_tx_pkt.o
CC hw/net/vmxnet_rx_pkt.o
CC hw/net/vmxnet3.o
CC hw/nvram/eeprom93xx.o
CC hw/net/ne2000-isa.o
CC hw/nvram/fw_cfg.o
CC hw/pci-bridge/pci_bridge_dev.o
CC hw/pci-bridge/ioh3420.o
CC hw/pci-bridge/xio3130_upstream.o
CC hw/pci-bridge/xio3130_downstream.o
CC hw/pci-bridge/i82801b11.o
CC hw/pci-host/pam.o
CC hw/pci-host/piix.o
CC hw/pci-host/q35.o
CC hw/pci/pci.o
CC hw/pci/pci_bridge.o
CC hw/pci/msix.o
CC hw/pci/msi.o
CC hw/pci/shpc.o
CC hw/pci/slotid_cap.o
CC hw/pci/pci_host.o
CC hw/pci/pcie_host.o
CC hw/pci/pcie.o
CC hw/pci/pcie_aer.o
CC hw/pci/pcie_port.o
CC hw/pci/pci-stub.o
CC hw/pci/pci-hotplug-old.o
CC hw/scsi/scsi-disk.o
CC hw/scsi/scsi-generic.o
CC hw/scsi/scsi-bus.o
CC hw/scsi/lsi53c895a.o
CC hw/scsi/megasas.o
CC hw/scsi/vmw_pvscsi.o
CC hw/scsi/esp.o
CC hw/scsi/esp-pci.o
CC hw/timer/hpet.o
CC hw/timer/i8254_common.o
CC hw/timer/i8254.o
CC hw/usb/core.o
CC hw/usb/combined-packet.o
CC hw/usb/bus.o
CC hw/usb/desc.o
CC hw/usb/libhw.o
CC hw/usb/hcd-uhci.o
CC hw/usb/hcd-ohci.o
CC hw/usb/hcd-ehci.o
CC hw/usb/hcd-ehci-pci.o
CC hw/usb/hcd-ehci-sysbus.o
CC hw/usb/hcd-xhci.o
CC hw/usb/dev-hub.o
CC hw/usb/dev-hid.o
CC hw/usb/dev-wacom.o
CC hw/usb/dev-storage.o
CC hw/usb/dev-uas.o
CC hw/usb/dev-audio.o
CC hw/usb/dev-serial.o
CC hw/usb/dev-network.o
CC hw/usb/dev-bluetooth.o
CC hw/usb/dev-smartcard-reader.o
CC hw/usb/ccid-card-passthru.o
CC hw/usb/host-stub.o
CC hw/virtio/virtio-rng.o
CC hw/virtio/virtio-pci.o
CC hw/virtio/virtio-bus.o
CC hw/virtio/virtio-mmio.o
CC hw/watchdog/watchdog.o
CC hw/watchdog/wdt_i6300esb.o
CC hw/watchdog/wdt_ib700.o
CPP optionrom/multiboot.asm
CPP optionrom/linuxboot.asm
CPP optionrom/kvmvapic.asm
AS optionrom/multiboot.o
AS optionrom/linuxboot.o
Building optionrom/multiboot.img
AS optionrom/kvmvapic.o
Building optionrom/linuxboot.img
Building optionrom/multiboot.raw
Building optionrom/linuxboot.raw
Building optionrom/kvmvapic.img
Signing optionrom/multiboot.bin
Signing optionrom/linuxboot.bin
Building optionrom/kvmvapic.raw
CC qemu-img.o
Signing optionrom/kvmvapic.bin
CC qapi-types.o
CC qapi-visit.o
CC trace/generated-events.o
AR libqemustub.a
CC qmp-marshal.o
CC trace/generated-tracers.o
AR libqemuutil.a
LINK qemu-img.exe
i686-w64-mingw32-gcc: error: /home/mdroth/qemu-build2/version.o: No such file or directory
LINK qemu-io.exe
make: *** [qemu-img.exe] Error 1
make: *** Waiting for unfinished jobs....
i686-w64-mingw32-gcc: error: /home/mdroth/qemu-build2/version.o: No such file or directory
make: *** [qemu-io.exe] Error 1
GEN x86_64-softmmu/hmp-commands.h
GEN x86_64-softmmu/qmp-commands-old.h
GEN x86_64-softmmu/config-target.h
CC x86_64-softmmu/exec.o
CC x86_64-softmmu/translate-all.o
CC x86_64-softmmu/cpu-exec.o
CC x86_64-softmmu/tcg/tcg.o
CC x86_64-softmmu/tcg/optimize.o
CC x86_64-softmmu/fpu/softfloat.o
CC x86_64-softmmu/disas.o
CC x86_64-softmmu/kvm-stub.o
CC x86_64-softmmu/arch_init.o
CC x86_64-softmmu/cpus.o
CC x86_64-softmmu/monitor.o
CC x86_64-softmmu/gdbstub.o
CC x86_64-softmmu/balloon.o
CC x86_64-softmmu/ioport.o
CC x86_64-softmmu/qtest.o
CC x86_64-softmmu/device_tree.o
CC x86_64-softmmu/memory.o
CC x86_64-softmmu/savevm.o
CC x86_64-softmmu/cputlb.o
CC x86_64-softmmu/memory_mapping.o
CC x86_64-softmmu/dump.o
CC x86_64-softmmu/xen-stub.o
CC x86_64-softmmu/hw/i386/multiboot.o
CC x86_64-softmmu/hw/i386/smbios.o
CC x86_64-softmmu/hw/i386/pc.o
CC x86_64-softmmu/hw/i386/pc_piix.o
CC x86_64-softmmu/hw/i386/pc_q35.o
CC x86_64-softmmu/hw/i386/pc_sysfw.o
CC x86_64-softmmu/hw/i386/kvmvapic.o
CC x86_64-softmmu/target-i386/translate.o
CC x86_64-softmmu/target-i386/helper.o
CC x86_64-softmmu/target-i386/cpu.o
CC x86_64-softmmu/target-i386/excp_helper.o
CC x86_64-softmmu/target-i386/fpu_helper.o
CC x86_64-softmmu/target-i386/cc_helper.o
CC x86_64-softmmu/target-i386/int_helper.o
CC x86_64-softmmu/target-i386/svm_helper.o
CC x86_64-softmmu/target-i386/smm_helper.o
CC x86_64-softmmu/target-i386/misc_helper.o
CC x86_64-softmmu/target-i386/mem_helper.o
CC x86_64-softmmu/target-i386/seg_helper.o
CC x86_64-softmmu/target-i386/gdbstub.o
CC x86_64-softmmu/target-i386/machine.o
CC x86_64-softmmu/target-i386/arch_memory_mapping.o
CC x86_64-softmmu/target-i386/arch_dump.o
CC x86_64-softmmu/target-i386/kvm-stub.o
CC x86_64-softmmu/hw/block/virtio-blk.o
CC x86_64-softmmu/hw/char/virtio-serial-bus.o
CC x86_64-softmmu/hw/cpu/icc_bus.o
CC x86_64-softmmu/hw/display/vga.o
CC x86_64-softmmu/hw/intc/apic.o
CC x86_64-softmmu/hw/intc/apic_common.o
CC x86_64-softmmu/hw/intc/ioapic.o
CC x86_64-softmmu/hw/isa/lpc_ich9.o
CC x86_64-softmmu/hw/misc/vmport.o
CC x86_64-softmmu/hw/misc/pvpanic.o
CC x86_64-softmmu/hw/net/virtio-net.o
CC x86_64-softmmu/hw/net/vhost_net.o
CC x86_64-softmmu/hw/scsi/virtio-scsi.o
CC x86_64-softmmu/hw/timer/mc146818rtc.o
CC x86_64-softmmu/hw/virtio/virtio.o
CC x86_64-softmmu/hw/virtio/virtio-balloon.o
LINK x86_64-softmmu/qemu-system-x86_64.exe
i686-w64-mingw32-gcc: error: /home/mdroth/qemu-build2/version.o: No such file or directory
make[1]: *** [qemu-system-x86_64.exe] Error 1
make: *** [subdir-x86_64-softmmu] Error 2
[mdroth@vm5 qemu-build2]$ make V=1
make -I/home/mdroth/w/qemu2.git/dtc VPATH=/home/mdroth/w/qemu2.git/dtc -C dtc V="1" LIBFDT_srcdir=/home/mdroth/w/qemu2.git/dtc/libfdt CPPFLAGS="-I/home/mdroth/qemu-build2/dtc -I/home/mdroth/w/qemu2.git/dtc -I/home/mdroth/w/qemu2.git/dtc/libfdt" CFLAGS="-O2 -D_FORTIFY_SOURCE=2 -g -m32 -D__USE_MINGW_ANSI_STDIO=1 -DWIN32_LEAN_AND_MEAN -DWINVER=0x501 -D_GNU_SOURCE -D_FILE_OFFSET_BITS=64 -D_LARGEFILE_SOURCE -Wstrict-prototypes -Wredundant-decls -Wall -Wundef -Wwrite-strings -Wmissing-prototypes -fno-strict-aliasing -Wendif-labels -Wmissing-include-dirs -Wempty-body -Wnested-externs -Wformat-security -Wformat-y2k -Winit-self -Wignored-qualifiers -Wold-style-declaration -Wold-style-definition -Wtype-limits -fstack-protector-all -I/usr/i686-w64-mingw32/sys-root/mingw/include -I/usr/i686-w64-mingw32/sys-root/mingw/include/p11-kit-1 -I/usr/i686-w64-mingw32/sys-root/mingw/include/pixman-1 -I/home/mdroth/w/qemu2.git/dtc/libfdt -mms-bitfields -I/usr/i686-w64-mingw32/sys-root/mingw/include/glib-2.0 -I/usr/i686-w64-mingw32/sys-root/mingw/lib/glib-2.0/include -I/home/mdroth/w/qemu2.git/tests" LDFLAGS="-Wl,--nxcompat -Wl,--no-seh -Wl,--dynamicbase -Wl,--warn-common -m32 -g " ARFLAGS="rv" CC="i686-w64-mingw32-gcc" AR="i686-w64-mingw32-ar" LD="i686-w64-mingw32-ld" BUILD_DIR=/home/mdroth/qemu-build2 libfdt/libfdt.a
make[1]: Entering directory `/home/mdroth/qemu-build2/dtc'
flex -oconvert-dtsv0-lexer.lex.c /home/mdroth/w/qemu2.git/dtc/convert-dtsv0-lexer.l
make[1]: flex: Command not found
bison -d /home/mdroth/w/qemu2.git/dtc/dtc-parser.y
make[1]: bison: Command not found
flex -odtc-lexer.lex.c /home/mdroth/w/qemu2.git/dtc/dtc-lexer.l
make[1]: flex: Command not found
make[1]: `libfdt/libfdt.a' is up to date.
make[1]: Leaving directory `/home/mdroth/qemu-build2/dtc'
i686-w64-mingw32-gcc -m32 -D__USE_MINGW_ANSI_STDIO=1 -DWIN32_LEAN_AND_MEAN -DWINVER=0x501 -D_GNU_SOURCE -D_FILE_OFFSET_BITS=64 -D_LARGEFILE_SOURCE -Wstrict-prototypes -Wredundant-decls -Wall -Wundef -Wwrite-strings -Wmissing-prototypes -fno-strict-aliasing -Wendif-labels -Wmissing-include-dirs -Wempty-body -Wnested-externs -Wformat-security -Wformat-y2k -Winit-self -Wignored-qualifiers -Wold-style-declaration -Wold-style-definition -Wtype-limits -fstack-protector-all -I/usr/i686-w64-mingw32/sys-root/mingw/include -I/usr/i686-w64-mingw32/sys-root/mingw/include/p11-kit-1 -I/usr/i686-w64-mingw32/sys-root/mingw/include/pixman-1 -I/home/mdroth/w/qemu2.git/dtc/libfdt -mms-bitfields -I/usr/i686-w64-mingw32/sys-root/mingw/include/glib-2.0 -I/usr/i686-w64-mingw32/sys-root/mingw/lib/glib-2.0/include -I/home/mdroth/w/qemu2.git/tests -O2 -D_FORTIFY_SOURCE=2 -g -Wl,--nxcompat -Wl,--no-seh -Wl,--dynamicbase -Wl,--warn-common -m32 -g -o qemu-img.exe aio-win32.o async.o block.o block/blkdebug.o block/blkverify.o block/bochs.o block/cloop.o block/cow.o block/dmg.o block/parallels.o block/qapi.o block/qcow.o block/qcow2-cache.o block/qcow2-cluster.o block/qcow2-refcount.o block/qcow2-snapshot.o block/qcow2.o block/qed-check.o block/qed-cluster.o block/qed-gencb.o block/qed-l2-cache.o block/qed-table.o block/qed.o block/raw-win32.o block/raw.o block/snapshot.o block/vdi.o block/vhdx.o block/vmdk.o block/vpc.o block/vvfat.o block/win32-aio.o blockjob.o coroutine-win32.o iohandler.o main-loop.o nbd.o qapi-types.o qapi-visit.o qemu-coroutine-io.o qemu-coroutine-lock.o qemu-coroutine-sleep.o qemu-coroutine.o qemu-img.o qemu-io-cmds.o qemu-timer.o thread-pool.o libqemuutil.a libqemustub.a /home/mdroth/qemu-build2/version.o -L/usr/i686-w64-mingw32/sys-root/mingw/lib -lgthread-2.0 -lglib-2.0 -lintl -lwinmm -lws2_32 -liphlpapi -lz
i686-w64-mingw32-gcc: error: /home/mdroth/qemu-build2/version.o: No such file or directory
make: *** [qemu-img.exe] Error 1
[mdroth@vm5 qemu-build2]$ find . | grep version
./dtc/version_gen.h
[mdroth@vm5 qemu-build2]$
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [Qemu-devel] [PATCH v2 for 1.6] w32: Add missing version.o to all executables (fix regression)
2013-08-15 22:19 ` Michael Roth
@ 2013-08-16 5:55 ` Stefan Weil
2013-08-16 18:27 ` Michael Roth
0 siblings, 1 reply; 6+ messages in thread
From: Stefan Weil @ 2013-08-16 5:55 UTC (permalink / raw)
To: Michael Roth; +Cc: Paolo Bonzini, Anthony Liguori, qemu-devel
[-- Attachment #1: Type: text/plain, Size: 2175 bytes --]
Am 16.08.2013 00:19, schrieb Michael Roth:
> Quoting Stefan Weil (2013-08-08 13:18:07)
>> > QEMU executables for w32, w64 had included meta information built from
>> > version.rc. These rules were changed several times some months ago.
>> >
>> > The latest version added version.o to the tools, but not to the system
>> > emulations.
>> >
>> > This patch adds the meta information to all system emulations again.
>> >
>> > Signed-off-by: Stefan Weil <sw@weilnetz.de>
> I seem to be getting build errors with this patch when doing a Fedora 18 mingw
> crossbuild. I thought it was specific to qemu-ga so I disabled it to confirm
> and it looks like version.o is never being built, so all targets fail when
> linking.
>
> Reverting this patch seems to fix things
>
That's strange. Exactly the same command line works on Debian wheezy.
version.o is built right at the beginning:
...
QOM debugging yes
GEN x86_64-softmmu/config-devices.mak
GEN qemu-options.def
GEN config-host.h
GEN qmp-commands.h
GEN qapi-types.h
GEN qapi-visit.h
GEN trace/generated-events.h
GEN trace/generated-tracers.h
GEN tests/test-qapi-types.h
GEN tests/test-qapi-visit.h
GEN tests/test-qmp-commands.h
GEN config-all-devices.mak
RC /home/stefan/src/qemu/qemu.org/spelling/version.o
rm /home/stefan/src/qemu/qemu.org/spelling/config-host.h-timestamp
GEN config-host.h
GEN qemu-monitor.texi
GEN qemu-img-cmds.texi
...
Here are the dependency rules which should trigger building of version.o:
$ grep version-.*obj Makefile* *mak
Makefile:Makefile: $(version-obj-y) $(version-lobj-y)
Makefile.objs:version-obj-$(CONFIG_WIN32) += $(BUILD_DIR)/version.o
Makefile.objs:version-lobj-$(CONFIG_WIN32) += $(BUILD_DIR)/version.lo
Could you please check the values of version-obj-y, version-lobj-y?
Do you use a special make program? Do you get the same problem when
running make without -j4 (no parallel build)?
My patch was a hack for 1.6, but I did not expect that it might cause
any problems. A better solution would extend version.rc and compile
it each time when linking, so version.o can include build information.
Regards,
Stefan
[-- Attachment #2: Type: text/html, Size: 4161 bytes --]
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [Qemu-devel] [PATCH v2 for 1.6] w32: Add missing version.o to all executables (fix regression)
2013-08-16 5:55 ` Stefan Weil
@ 2013-08-16 18:27 ` Michael Roth
2013-08-16 18:42 ` Michael Roth
0 siblings, 1 reply; 6+ messages in thread
From: Michael Roth @ 2013-08-16 18:27 UTC (permalink / raw)
To: Stefan Weil; +Cc: Paolo Bonzini, Anthony Liguori, qemu-devel
Quoting Stefan Weil (2013-08-16 00:55:07)
> Am 16.08.2013 00:19, schrieb Michael Roth:
>
> Quoting Stefan Weil (2013-08-08 13:18:07)
>
> > QEMU executables for w32, w64 had included meta information built from
> > version.rc. These rules were changed several times some months ago.
> >
> > The latest version added version.o to the tools, but not to the system
> > emulations.
> >
> > This patch adds the meta information to all system emulations again.
> >
> > Signed-off-by: Stefan Weil <sw@weilnetz.de>
>
> I seem to be getting build errors with this patch when doing a Fedora 18 mingw
> crossbuild. I thought it was specific to qemu-ga so I disabled it to confirm
> and it looks like version.o is never being built, so all targets fail when
> linking.
>
> Reverting this patch seems to fix things
>
>
> That's strange. Exactly the same command line works on Debian wheezy.
> version.o is built right at the beginning:
>
> ...
> QOM debugging yes
> GEN x86_64-softmmu/config-devices.mak
> GEN qemu-options.def
> GEN config-host.h
> GEN qmp-commands.h
> GEN qapi-types.h
> GEN qapi-visit.h
> GEN trace/generated-events.h
> GEN trace/generated-tracers.h
> GEN tests/test-qapi-types.h
> GEN tests/test-qapi-visit.h
> GEN tests/test-qmp-commands.h
> GEN config-all-devices.mak
> RC /home/stefan/src/qemu/qemu.org/spelling/version.o
> rm /home/stefan/src/qemu/qemu.org/spelling/config-host.h-timestamp
> GEN config-host.h
> GEN qemu-monitor.texi
> GEN qemu-img-cmds.texi
> ...
>
> Here are the dependency rules which should trigger building of version.o:
>
> $ grep version-.*obj Makefile* *mak
> Makefile:Makefile: $(version-obj-y) $(version-lobj-y)
> Makefile.objs:version-obj-$(CONFIG_WIN32) += $(BUILD_DIR)/version.o
> Makefile.objs:version-lobj-$(CONFIG_WIN32) += $(BUILD_DIR)/version.lo
mdroth@loki:~/w/qemu2.git$ grep version-.*obj Makefile* *mak
Makefile:Makefile: $(version-obj-y) $(version-lobj-y)
Makefile.objs:version-obj-$(CONFIG_WIN32) += $(BUILD_DIR)/version.o
Makefile.objs:version-lobj-$(CONFIG_WIN32) += $(BUILD_DIR)/version.lo
rules.mak: $(sort $(filter %.o, $1)) $(filter-out %.o, $1) $(version-obj-y) \
rules.mak: $(if $(filter %.lo %.la,$^),$(version-lobj-y),$(version-obj-y)) \
>
> Could you please check the values of version-obj-y, version-lobj-y?
> Do you use a special make program? Do you get the same problem when
> running make without -j4 (no parallel build)?
Same issue with non-parallel build, first link target is qemu-img
which fails due to missing version.o
At qemu-img link time, the actual values of version-{lobj,obj}-y are:
version-obj-y: /home/mdroth/dev/kvm/qemu-build2/version.o
version-lobj-y: /home/mdroth/dev/kvm/qemu-build2/version.lo
No special make either:
[mdroth@vm5 qemu-build2]$ make -v
GNU Make 3.82
Built for x86_64-redhat-linux-gnu
Copyright (C) 2010 Free Software Foundation, Inc.
License GPLv3+: GNU GPL version 3 or later <http://gnu.org/licenses/gpl.html>
This is free software: you are free to change and redistribute it.
There is NO WARRANTY, to the extent permitted by law.
[mdroth@vm5 qemu-build2]$
I can get everything to build with the following patch, so I suspect it
has something to do with the the non-relative target paths for
version.o/.lo causing us to no longer matching the $(WINDRES) recipe in
rules.mak in certain environments:
diff --git a/Makefile b/Makefile
index 4d257f1..3e9416f 100644
--- a/Makefile
+++ b/Makefile
@@ -168,6 +168,7 @@ recurse-all: $(SUBDIR_RULES) $(ROMSUBDIR_RULES)
bt-host.o: QEMU_CFLAGS += $(BLUEZ_CFLAGS)
$(BUILD_DIR)/version.o: $(SRC_PATH)/version.rc $(BUILD_DIR)/config-host.h | $(BUILD_DIR)/version.lo
+ $(call quiet-command,$(WINDRES) -I. -o $@ $<," RC $(TARGET_DIR)$@")
$(BUILD_DIR)/version.lo: $(SRC_PATH)/version.rc $(BUILD_DIR)/config-host.h
Makefile: $(version-obj-y) $(version-lobj-y)
>
> My patch was a hack for 1.6, but I did not expect that it might cause
> any problems. A better solution would extend version.rc and compile
> it each time when linking, so version.o can include build information.
>
> Regards,
> Stefan
^ permalink raw reply related [flat|nested] 6+ messages in thread* Re: [Qemu-devel] [PATCH v2 for 1.6] w32: Add missing version.o to all executables (fix regression)
2013-08-16 18:27 ` Michael Roth
@ 2013-08-16 18:42 ` Michael Roth
0 siblings, 0 replies; 6+ messages in thread
From: Michael Roth @ 2013-08-16 18:42 UTC (permalink / raw)
To: Stefan Weil; +Cc: Paolo Bonzini, Anthony Liguori, qemu-devel
Quoting Michael Roth (2013-08-16 13:27:32)
> Quoting Stefan Weil (2013-08-16 00:55:07)
> > Am 16.08.2013 00:19, schrieb Michael Roth:
> >
> > Quoting Stefan Weil (2013-08-08 13:18:07)
> >
> > > QEMU executables for w32, w64 had included meta information built from
> > > version.rc. These rules were changed several times some months ago.
> > >
> > > The latest version added version.o to the tools, but not to the system
> > > emulations.
> > >
> > > This patch adds the meta information to all system emulations again.
> > >
> > > Signed-off-by: Stefan Weil <sw@weilnetz.de>
> >
> > I seem to be getting build errors with this patch when doing a Fedora 18 mingw
> > crossbuild. I thought it was specific to qemu-ga so I disabled it to confirm
> > and it looks like version.o is never being built, so all targets fail when
> > linking.
> >
> > Reverting this patch seems to fix things
> >
> >
> > That's strange. Exactly the same command line works on Debian wheezy.
> > version.o is built right at the beginning:
> >
> > ...
> > QOM debugging yes
> > GEN x86_64-softmmu/config-devices.mak
> > GEN qemu-options.def
> > GEN config-host.h
> > GEN qmp-commands.h
> > GEN qapi-types.h
> > GEN qapi-visit.h
> > GEN trace/generated-events.h
> > GEN trace/generated-tracers.h
> > GEN tests/test-qapi-types.h
> > GEN tests/test-qapi-visit.h
> > GEN tests/test-qmp-commands.h
> > GEN config-all-devices.mak
> > RC /home/stefan/src/qemu/qemu.org/spelling/version.o
> > rm /home/stefan/src/qemu/qemu.org/spelling/config-host.h-timestamp
> > GEN config-host.h
> > GEN qemu-monitor.texi
> > GEN qemu-img-cmds.texi
> > ...
> >
> > Here are the dependency rules which should trigger building of version.o:
> >
> > $ grep version-.*obj Makefile* *mak
> > Makefile:Makefile: $(version-obj-y) $(version-lobj-y)
> > Makefile.objs:version-obj-$(CONFIG_WIN32) += $(BUILD_DIR)/version.o
> > Makefile.objs:version-lobj-$(CONFIG_WIN32) += $(BUILD_DIR)/version.lo
>
> mdroth@loki:~/w/qemu2.git$ grep version-.*obj Makefile* *mak
> Makefile:Makefile: $(version-obj-y) $(version-lobj-y)
> Makefile.objs:version-obj-$(CONFIG_WIN32) += $(BUILD_DIR)/version.o
> Makefile.objs:version-lobj-$(CONFIG_WIN32) += $(BUILD_DIR)/version.lo
> rules.mak: $(sort $(filter %.o, $1)) $(filter-out %.o, $1) $(version-obj-y) \
> rules.mak: $(if $(filter %.lo %.la,$^),$(version-lobj-y),$(version-obj-y)) \
>
> >
> > Could you please check the values of version-obj-y, version-lobj-y?
> > Do you use a special make program? Do you get the same problem when
> > running make without -j4 (no parallel build)?
>
> Same issue with non-parallel build, first link target is qemu-img
> which fails due to missing version.o
>
> At qemu-img link time, the actual values of version-{lobj,obj}-y are:
>
> version-obj-y: /home/mdroth/dev/kvm/qemu-build2/version.o
> version-lobj-y: /home/mdroth/dev/kvm/qemu-build2/version.lo
I should add that in my original log output i was in
/home/mdroth/qemu-build2, accidentially did the build in
/home/mdroth/w/qemu-build2 this time around, which is a symlink to
/home/mdroth/dev/kvm/qemu-build2
I started suspecting maybe the symlinks were causing issues
with the recipe matching, and just now redid the build in
/home/mdroth/qemu-build2, but problem still remained.
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2013-08-16 18:42 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-08-08 18:18 [Qemu-devel] [PATCH v2 for 1.6] w32: Add missing version.o to all executables (fix regression) Stefan Weil
2013-08-14 16:27 ` Anthony Liguori
2013-08-15 22:19 ` Michael Roth
2013-08-16 5:55 ` Stefan Weil
2013-08-16 18:27 ` Michael Roth
2013-08-16 18:42 ` Michael Roth
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).