From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:45896)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <lcapitulino@redhat.com>) id 1VBPRk-0007WT-Du
	for qemu-devel@nongnu.org; Mon, 19 Aug 2013 09:24:41 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <lcapitulino@redhat.com>) id 1VBPPZ-0004ey-DB
	for qemu-devel@nongnu.org; Mon, 19 Aug 2013 09:22:29 -0400
Received: from mx1.redhat.com ([209.132.183.28]:55832)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <lcapitulino@redhat.com>) id 1VBPPZ-0004eZ-3j
	for qemu-devel@nongnu.org; Mon, 19 Aug 2013 09:22:21 -0400
Date: Mon, 19 Aug 2013 09:22:16 -0400
From: Luiz Capitulino <lcapitulino@redhat.com>
Message-ID: <20130819092216.511d3990@redhat.com>
In-Reply-To: <CAFEAcA8oFc6r8h4ibfCJNWwa==gzA+DA-h4qAw+mk3HFvMoGwA@mail.gmail.com>
References: <1609927484.62705.1376639964118.open-xchange@email.1und1.de>
	<CAFEAcA8oFc6r8h4ibfCJNWwa==gzA+DA-h4qAw+mk3HFvMoGwA@mail.gmail.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [Bug?] qemu-1.6.0 python traceback in GEN
 qmp-commands.h
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Peter Maydell <peter.maydell@linaro.org>
Cc: Erik Rull <erik.rull@rdsoftware.de>, "qemu-devel@nongnu.org" <qemu-devel@nongnu.org>

On Fri, 16 Aug 2013 14:21:50 +0100
Peter Maydell <peter.maydell@linaro.org> wrote:

> On 16 August 2013 08:59, Erik Rull <erik.rull@rdsoftware.de> wrote:
> > Hi all,
> >
> > when using the released qemu-1.6.0.tar.bz2, I get the following error message:
> >   File "/home/erik/qemu-1.6.0/scripts/qapi.py", line 164
> >     except QAPISchemaError as e:
> >                             ^
> > SyntaxError: invalid syntax
> > make: *** [qmp-commands.h] Error 1
> 
> My guess is that your python is older than 2.6; I think
> the "except Foo as e" syntax is new in 2.6. We probably
> missed this because most people use a newer Python than
> 2.6, but configure's check only requires 2.4 or better.
> 
> We should probably update the scripts to not use overly
> new features (or alternatively decide that 2.6 is our new
> minimum -- what do RHEL5 and our other oldest-supported
> distros ship?)
> 
> For this specific case I think it needs to change to
>      except QAPISchemaError, e:

Erik, can you try that and post a patch? Would be interesting
to know if this is the only problem with older python.