From: Kevin Wolf <kwolf@redhat.com>
To: Paolo Bonzini <pbonzini@redhat.com>
Cc: aliguori@us.ibm.com, Laszlo Ersek <lersek@redhat.com>,
hch@lst.de, qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH 7/7] switch raw block driver from "raw.o" to "raw_bsd.o"
Date: Tue, 20 Aug 2013 09:51:33 +0200 [thread overview]
Message-ID: <20130820075133.GA2384@dhcp-200-207.str.redhat.com> (raw)
In-Reply-To: <5210DA3B.3050401@redhat.com>
Am 18.08.2013 um 16:29 hat Paolo Bonzini geschrieben:
> Il 16/08/2013 16:15, Laszlo Ersek ha scritto:
> > +static int raw_reopen_prepare(BDRVReopenState *reopen_state,
> > + BlockReopenQueue *queue, Error **errp)
> > {
> > - return bdrv_reopen_prepare(bs->file);
> > + BDRVReopenState tmp = *reopen_state;
> > +
> > + tmp.bs = tmp.bs->file;
> > + return bdrv_reopen_prepare(&tmp, queue, errp);
> > }
>
> This should just return zero, my fault.
Which is because bdrv_reopen_queue() already queues bs->file for reopen.
The simple return 0; implementation is shared by all other format drivers
that support reopening images.
Kevin
next prev parent reply other threads:[~2013-08-20 7:51 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-08-16 14:15 [Qemu-devel] [PATCH 0/7] introduce BSD-licensed block driver for "raw" Laszlo Ersek
2013-08-16 14:15 ` [Qemu-devel] [PATCH 1/7] add skeleton for BSD licensed "raw" BlockDriver Laszlo Ersek
2013-08-16 14:15 ` [Qemu-devel] [PATCH 2/7] raw_bsd: emit debug events in bdrv_co_readv() and bdrv_co_writev() Laszlo Ersek
2013-08-16 14:15 ` [Qemu-devel] [PATCH 3/7] raw_bsd: add raw_create() Laszlo Ersek
2013-08-16 14:15 ` [Qemu-devel] [PATCH 4/7] raw_bsd: introduce "special members" Laszlo Ersek
2013-08-20 8:11 ` Kevin Wolf
2013-08-16 14:15 ` [Qemu-devel] [PATCH 5/7] raw_bsd: add raw_create_options Laszlo Ersek
2013-08-16 14:15 ` [Qemu-devel] [PATCH 6/7] raw_bsd: register bdrv_raw Laszlo Ersek
2013-08-16 14:15 ` [Qemu-devel] [PATCH 7/7] switch raw block driver from "raw.o" to "raw_bsd.o" Laszlo Ersek
2013-08-18 14:29 ` Paolo Bonzini
2013-08-20 7:51 ` Kevin Wolf [this message]
2013-08-16 14:59 ` [Qemu-devel] [PATCH 0/7] introduce BSD-licensed block driver for "raw" Anthony Liguori
2013-08-16 15:06 ` Daniel P. Berrange
2013-08-18 14:25 ` Paolo Bonzini
2013-08-19 16:24 ` Laszlo Ersek
2013-08-20 8:21 ` Kevin Wolf
2013-08-21 8:20 ` Laszlo Ersek
2013-08-21 9:03 ` Paolo Bonzini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130820075133.GA2384@dhcp-200-207.str.redhat.com \
--to=kwolf@redhat.com \
--cc=aliguori@us.ibm.com \
--cc=hch@lst.de \
--cc=lersek@redhat.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).