From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:50123)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <kwolf@redhat.com>) id 1VBgj4-0003Ea-7h
	for qemu-devel@nongnu.org; Tue, 20 Aug 2013 03:51:43 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <kwolf@redhat.com>) id 1VBgiy-0002RK-Sd
	for qemu-devel@nongnu.org; Tue, 20 Aug 2013 03:51:38 -0400
Received: from mx1.redhat.com ([209.132.183.28]:47464)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <kwolf@redhat.com>) id 1VBgiy-0002RF-LE
	for qemu-devel@nongnu.org; Tue, 20 Aug 2013 03:51:32 -0400
Date: Tue, 20 Aug 2013 09:51:33 +0200
From: Kevin Wolf <kwolf@redhat.com>
Message-ID: <20130820075133.GA2384@dhcp-200-207.str.redhat.com>
References: <1376662507-5212-1-git-send-email-lersek@redhat.com>
	<1376662507-5212-8-git-send-email-lersek@redhat.com>
	<5210DA3B.3050401@redhat.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <5210DA3B.3050401@redhat.com>
Subject: Re: [Qemu-devel] [PATCH 7/7] switch raw block driver from "raw.o"
 to "raw_bsd.o"
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Paolo Bonzini <pbonzini@redhat.com>
Cc: aliguori@us.ibm.com, Laszlo Ersek <lersek@redhat.com>, hch@lst.de, qemu-devel@nongnu.org

Am 18.08.2013 um 16:29 hat Paolo Bonzini geschrieben:
> Il 16/08/2013 16:15, Laszlo Ersek ha scritto:
> > +static int raw_reopen_prepare(BDRVReopenState *reopen_state,
> > +                              BlockReopenQueue *queue, Error **errp)
> >  {
> > -    return bdrv_reopen_prepare(bs->file);
> > +    BDRVReopenState tmp = *reopen_state;
> > +
> > +    tmp.bs = tmp.bs->file;
> > +    return bdrv_reopen_prepare(&tmp, queue, errp);
> >  }
> 
> This should just return zero, my fault.

Which is because bdrv_reopen_queue() already queues bs->file for reopen.
The simple return 0; implementation is shared by all other format drivers
that support reopening images.

Kevin