From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:58176) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VBhCP-0004pv-GQ for qemu-devel@nongnu.org; Tue, 20 Aug 2013 04:22:03 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1VBhCI-0005Kn-Sy for qemu-devel@nongnu.org; Tue, 20 Aug 2013 04:21:57 -0400 Received: from mx1.redhat.com ([209.132.183.28]:54751) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VBhCI-0005KU-LL for qemu-devel@nongnu.org; Tue, 20 Aug 2013 04:21:50 -0400 Date: Tue, 20 Aug 2013 10:21:51 +0200 From: Kevin Wolf Message-ID: <20130820082151.GC2384@dhcp-200-207.str.redhat.com> References: <1376662507-5212-1-git-send-email-lersek@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1376662507-5212-1-git-send-email-lersek@redhat.com> Subject: Re: [Qemu-devel] [PATCH 0/7] introduce BSD-licensed block driver for "raw" List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Laszlo Ersek Cc: pbonzini@redhat.com, aliguori@us.ibm.com, hch@lst.de, stefanha@redhat.com, qemu-devel@nongnu.org Am 16.08.2013 um 16:15 hat Laszlo Ersek geschrieben: > Paolo asked me to write such a driver based on his textual specification > alone. The first patch captures his email in full, the rest re-quotes > parts that are being implemented. > > The tree compiles at each patch. The series passes "make check-block". > > "block/raw.c" is not removed because I wanted to keep it out of my > series and out of my brain. > > Disclaimer: I couldn't care less if the raw block driver was public > domain or AGPLv3+, as long as it qualifies as free software. I'm only > trying to do what Paolo asked of me. > > Laszlo Ersek (7): > add skeleton for BSD licensed "raw" BlockDriver > raw_bsd: emit debug events in bdrv_co_readv() and bdrv_co_writev() > raw_bsd: add raw_create() > raw_bsd: introduce "special members" > raw_bsd: add raw_create_options > raw_bsd: register bdrv_raw > switch raw block driver from "raw.o" to "raw_bsd.o" > > block/Makefile.objs | 2 +- > block/raw_bsd.c | 186 +++++++++++++++++++++++++++++++++++++++++++++++++++ > 2 files changed, 187 insertions(+), 1 deletions(-) > create mode 100644 block/raw_bsd.c Reviewed if the individual added functions make sense, whether all necessary function from struct BlockDriver are implemented, and which fields from BlockDriverState need special handling (it's only bs->sg, and we should probably get rid of that requirement) Looks good in general, but please CC Stefan and me for v2 (like for all block patches). Kevin