From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:38937)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <lcapitulino@redhat.com>) id 1VBoHP-0005Ts-1H
	for qemu-devel@nongnu.org; Tue, 20 Aug 2013 11:55:39 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <lcapitulino@redhat.com>) id 1VBoHK-0005BG-4i
	for qemu-devel@nongnu.org; Tue, 20 Aug 2013 11:55:34 -0400
Date: Tue, 20 Aug 2013 11:43:53 -0400
From: Luiz Capitulino <lcapitulino@redhat.com>
Message-ID: <20130820114353.59aefd40@redhat.com>
In-Reply-To: <1377010215-5470-1-git-send-email-peter.maydell@linaro.org>
References: <1377010215-5470-1-git-send-email-peter.maydell@linaro.org>
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH] scripts/qapi.py: Avoid syntax not
 supported by Python 2.4
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Peter Maydell <peter.maydell@linaro.org>
Cc: Stefan Hajnoczi <stefanha@gmail.com>, Erik Rull <erik.rull@rdsoftware.de>, qemu-devel@nongnu.org, Andreas =?UTF-8?B?RsOkcmJlcg==?= <afaerber@suse.de>, qemu-stable@nongnu.org

On Tue, 20 Aug 2013 15:50:15 +0100
Peter Maydell <peter.maydell@linaro.org> wrote:

> The Python "except Foo as x" syntax was only introduced in
> Python 2.6, but we aim to support Python 2.4 and later.
> Use the old-style "except Foo, x" syntax instead, thus
> fixing configure/compile on systems with older Python.
> 
> Signed-off-by: Peter Maydell <peter.maydell@linaro.org>

Applied to the qmp branch, thanks.

> ---
> I don't have an old python to test this on, but it works
> OK with 2.7 and Erik said he'd tested the equivalent
> change done by hand.
> 
>  scripts/qapi.py |    2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/scripts/qapi.py b/scripts/qapi.py
> index 0ebea94..1069310 100644
> --- a/scripts/qapi.py
> +++ b/scripts/qapi.py
> @@ -161,7 +161,7 @@ class QAPISchema:
>  def parse_schema(fp):
>      try:
>          schema = QAPISchema(fp)
> -    except QAPISchemaError as e:
> +    except QAPISchemaError, e:
>          print >>sys.stderr, e
>          exit(1)
>