qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Stefan Hajnoczi <stefanha@gmail.com>
To: "Andreas Färber" <afaerber@suse.de>
Cc: Peter Maydell <peter.maydell@linaro.org>,
	"qemu-devel@nongnu.org" <qemu-devel@nongnu.org>,
	Erik Rull <erik.rull@rdsoftware.de>
Subject: Re: [Qemu-devel] [Bug?] qemu-1.6.0 python traceback in GEN qmp-commands.h
Date: Tue, 20 Aug 2013 16:37:45 +0200	[thread overview]
Message-ID: <20130820143745.GB5536@stefanha-thinkpad.redhat.com> (raw)
In-Reply-To: <521222B5.2050202@suse.de>

On Mon, Aug 19, 2013 at 03:50:45PM +0200, Andreas Färber wrote:
> Am 16.08.2013 15:21, schrieb Peter Maydell:
> > On 16 August 2013 08:59, Erik Rull <erik.rull@rdsoftware.de> wrote:
> >> Hi all,
> >>
> >> when using the released qemu-1.6.0.tar.bz2, I get the following error message:
> >>   File "/home/erik/qemu-1.6.0/scripts/qapi.py", line 164
> >>     except QAPISchemaError as e:
> >>                             ^
> >> SyntaxError: invalid syntax
> >> make: *** [qmp-commands.h] Error 1
> > 
> > My guess is that your python is older than 2.6; I think
> > the "except Foo as e" syntax is new in 2.6. We probably
> > missed this because most people use a newer Python than
> > 2.6, but configure's check only requires 2.4 or better.
> > 
> > We should probably update the scripts to not use overly
> > new features (or alternatively decide that 2.6 is our new
> > minimum -- what do RHEL5 and our other oldest-supported
> > distros ship?)
> 
> I vaguely remember running into such problems before... possibly on
> Solaris. We compiled a list of Python versions and I think settled for
> 2.4 based on some old RHEL, too. CC'ing Stefan.
> 
> git-blame points to:
> http://repo.or.cz/w/qemu.git/commit/e120d449e1b39ec508c297b963ce452628dd37c3?f=configure

Yes, we should write Python 2.4+ code so that even oldish distros can
execute our scripts.

Stefan

  reply	other threads:[~2013-08-20 14:38 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-08-16  7:59 [Qemu-devel] [Bug?] qemu-1.6.0 python traceback in GEN qmp-commands.h Erik Rull
2013-08-16 13:12 ` Luiz Capitulino
2013-08-16 13:21 ` Peter Maydell
2013-08-19 13:22   ` Luiz Capitulino
2013-08-19 16:15     ` Erik Rull
2013-08-20  7:22       ` Erik Rull
2013-08-19 13:50   ` Andreas Färber
2013-08-20 14:37     ` Stefan Hajnoczi [this message]
2013-08-16 13:42 ` Markus Armbruster

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20130820143745.GB5536@stefanha-thinkpad.redhat.com \
    --to=stefanha@gmail.com \
    --cc=afaerber@suse.de \
    --cc=erik.rull@rdsoftware.de \
    --cc=peter.maydell@linaro.org \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).